From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: kernel test robot <lkp@intel.com>, <broonie@kernel.org>,
<lgirdwood@gmail.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<kbuild-all@lists.01.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: ti: j721e-evm: Add support for j7200-cpb audio
Date: Thu, 10 Sep 2020 15:27:50 +0300 [thread overview]
Message-ID: <9379c7b5-1cf4-3d10-ce6e-0a1b0b16bc72@ti.com> (raw)
In-Reply-To: <e32444ee-542d-1daf-0fa3-be4d280aef35@ti.com>
On 10/09/2020 14.48, Peter Ujfalusi wrote:
> Hi,
>
> On 10/09/2020 12.54, kernel test robot wrote:
>> Hi Peter,
>>
>> I love your patch! Perhaps something to improve:
>>
>> [auto build test WARNING on asoc/for-next]
>> [also build test WARNING on v5.9-rc4 next-20200909]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url: https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>> config: m68k-allmodconfig (attached as .config)
>> compiler: m68k-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> sound/soc/ti/j721e-evm.c:532:3: warning: this decimal constant is unsigned only in ISO C90
>> 532 | [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */
>> | ^
>>
>> # https://github.com/0day-ci/linux/commit/63afa4709f3914bb58dd727c1119c447a23ce150
>> git remote add linux-review https://github.com/0day-ci/linux
>> git fetch --no-tags linux-review Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534
>> git checkout 63afa4709f3914bb58dd727c1119c447a23ce150
>> vim +532 sound/soc/ti/j721e-evm.c
>>
>> 527
>> 528 static const struct j721e_audio_match_data j7200_cpb_data = {
>> 529 .board_type = J721E_BOARD_CPB,
>> 530 .num_links = 2, /* CPB pcm3168a */
>> 531 .pll_rates = {
>> > 532 [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */
Suffixing with 'u' silences the warning for C90, I'll send v2
>
> struct j721e_audio_match_data {
> enum j721e_board_type board_type;
> int num_links;
> unsigned int pll_rates[2];
> };
>
> pll_rates _is_ unsigned int.
>
>> 533 },
>> 534 };
>> 535
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-09-10 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 7:54 [PATCH 0/2] ASoC: ti: j721e-evm: Support for j7200 variant Peter Ujfalusi
2020-09-10 7:54 ` [PATCH 1/2] ASoC: dt-bindings: ti,j721e-cpb-audio: Document support for j7200-cpb Peter Ujfalusi
2020-09-10 7:54 ` [PATCH 2/2] ASoC: ti: j721e-evm: Add support for j7200-cpb audio Peter Ujfalusi
[not found] ` <202009101750.MT0BQY74%lkp@intel.com>
2020-09-10 11:48 ` Peter Ujfalusi
2020-09-10 12:27 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9379c7b5-1cf4-3d10-ce6e-0a1b0b16bc72@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).