From: <Tristram.Ha@microchip.com>
To: <pavel@ucw.cz>
Cc: <andrew@lunn.ch>, <muvarov@gmail.com>,
<nathan.leigh.conrad@gmail.com>,
<vivien.didelot@savoirfairelinux.com>, <f.fainelli@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Woojung.Huh@microchip.com>
Subject: RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.
Date: Sat, 9 Sep 2017 01:10:31 +0000 [thread overview]
Message-ID: <93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com> (raw)
In-Reply-To: <20170908085405.GB16834@amd>
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@ucw.cz]
> Sent: Friday, September 08, 2017 1:54 AM
> To: Tristram Ha - C24268
> Cc: andrew@lunn.ch; muvarov@gmail.com; nathan.leigh.conrad@gmail.com;
> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh -
> C21699
> Subject: Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to
> add other KSZ switch drivers.
>
> Hi!
>
> > From: Tristram Ha <Tristram.Ha@microchip.com>
> >
> > This series of patches is to modify the original KSZ9477 DSA driver so that
> other KSZ switch drivers can be added and use the common code.
> >
>
> Please wrap the lines from time to time...
>
>
> > This patch set is against net-next.
> >
> > drivers/net/dsa/microchip/Makefile | 2 +-
> > drivers/net/dsa/microchip/ksz9477.c | 1317
> ++++++++++++++++++++++++++++++++
>
> We already have ksz_9477_reg.h. So should this be ksz_9477.c for
> consistency?
The product name is KSZ9477 and other switches are also like KSZ####,
so I would prefer to have no separation between KSZ and the product
number. I think the file ksz_9477_reg.h was named that way because
the other files were named ksz_common.c and ksz_spi.c. If need to
we can change the file name.
next prev parent reply other threads:[~2017-09-09 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <93AF473E2DA327428DE3D46B72B1E9FD411218B7@CHN-SV-EXMX02.mchp-main.com>
2017-09-07 21:08 ` [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers Tristram.Ha
2017-09-08 8:54 ` Pavel Machek
2017-09-09 1:10 ` Tristram.Ha [this message]
2017-09-28 15:24 ` Pavel Machek
2017-09-08 13:30 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com \
--to=tristram.ha@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muvarov@gmail.com \
--cc=nathan.leigh.conrad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).