From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F3CC2D0A8 for ; Mon, 28 Sep 2020 21:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03EDB2100A for ; Mon, 28 Sep 2020 21:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="v51yHcg3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726959AbgI1VgG (ORCPT ); Mon, 28 Sep 2020 17:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726668AbgI1VgG (ORCPT ); Mon, 28 Sep 2020 17:36:06 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47471C061755 for ; Mon, 28 Sep 2020 14:36:06 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id 7so2041263pgm.11 for ; Mon, 28 Sep 2020 14:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=9CeopZp8WY9RSvM4Dc5FY/xYVy88bbr1SqV3oic9qQA=; b=v51yHcg3rrbkOLHvDLP9ouUMsXf2KuP7FFSjqT+4AgwsxzYcIHJD5gmGrem3vz7s/V fOOZiCdjAjDdW+c5RSL5TuhE4kFl9lIrFcRJJnaM9dACSpDD77eFqxFUtfhe/tFunr+3 jiXKN9H9w/zrvuP1iT/OaEvb9ELPJhwJ5JddGeZJ0zkekFwqUJ1mw2bsZfONZpyUiFCw hdBdcPeTPzCr1QBhjT+pF8TItWq8t7qJFVFPAXSFlVK6VYv5m+4JWvzEecxs8JhMMafc 1ZF74dyj2CXLM1J5u2fcLiNRREzTHd/fuQLBxxR11xyTzZNTv+uzYiKDudPx+Phqmw7W KtiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=9CeopZp8WY9RSvM4Dc5FY/xYVy88bbr1SqV3oic9qQA=; b=LASUL7WBzYSbJXpXEmzCNl8fmWCxOXDlqqAQ4iIO0GjMdIXlYUFKytJ13gSHk1dMuX +5I10rqfxxu+3S/6VCZJKO3s60tY9UIABIhGGBMIK+h5gevA6oGFoA5wedyoWPt/mRFo 7he6rlgEgp9Njf7lrlKmSUstNBZZbUUBt5gW59OF7+93XyaEkGr+BCw1pSBi0wM4dw+r 00L7p0ymEV6O4ePy7SvllHFEJbFe/1LMAlpcV3Y8oZpH6NQvx8vRQXdxEWsGlGEl/KWu wMkdk3axODmbC6KdJu+XhfzZ6l+lxNp/mu2fdn7r1aMDfpA94/wUL2SMaW4qUr7BvBS/ pc9A== X-Gm-Message-State: AOAM531HvcBv9Hj0QwRH5amp3B0NwU92Y3gRlESjgzYdj8/iiG1Coi+3 rCDgMqDvAcaIB3U5bnr4LNBmHQ== X-Google-Smtp-Source: ABdhPJw28AorJK6x/SMLDvlhDyx8HInlpiwTMaNwmhH7iD/ET6ohf55xsQzWW/a1KDHOohXFAGjIaA== X-Received: by 2002:a17:902:b789:b029:d2:63a5:d3f0 with SMTP id e9-20020a170902b789b02900d263a5d3f0mr1273387pls.81.1601328965826; Mon, 28 Sep 2020 14:36:05 -0700 (PDT) Received: from [10.251.155.156] ([192.55.55.45]) by smtp.gmail.com with ESMTPSA id s24sm2263457pjp.53.2020.09.28.14.36.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Sep 2020 14:36:05 -0700 (PDT) From: "Sean V Kelley" To: "Bjorn Helgaas" Cc: "Sean V Kelley" , bhelgaas@google.com, Jonathan.Cameron@huawei.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@intel.com, qiuxu.zhuo@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/10] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR Date: Mon, 28 Sep 2020 14:36:00 -0700 X-Mailer: MailMate (1.13.2r5673) Message-ID: <93B0C872-C440-484A-9908-2D5B974595CD@intel.com> In-Reply-To: <20200928014711.GA2475864@bjorn-Precision-5520> References: <20200928014711.GA2475864@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 Sep 2020, at 18:47, Bjorn Helgaas wrote: > On Sun, Sep 27, 2020 at 06:45:45PM -0500, Bjorn Helgaas wrote: >> On Tue, Sep 22, 2020 at 02:38:56PM -0700, Sean V Kelley wrote: >>> From: Qiuxu Zhuo > >>> pci_dbg(dev, "broadcast error_detected message\n"); >>> if (state == pci_channel_io_frozen) { >>> - pci_bridge_walk(bridge, report_frozen_detected, &status); >>> + pci_bridge_walk(bridge, dev, report_frozen_detected, &status); >>> if (type == PCI_EXP_TYPE_RC_END) { >>> + /* >>> + * The callback only clears the Root Error Status >>> + * of the RCEC (see aer.c). >>> + */ >>> + if (bridge) >>> + reset_subordinate_devices(bridge); >> >> It's unfortunate to add yet another special case in this code, and >> I'm >> not thrilled about the one in aer_root_reset() either. It's just not >> obvious why they should be there. I'm sure if I spent 30 minutes >> decoding things, it would all make sense. Guess I'm just griping >> because I don't have a better suggestion. > > I'm sorry, this was unkind of me. If I don't have a constructive > idea, there's no reason for me to complain about this. I apologize. > > Bjorn No worries at all. The unfortunate handling of the Spec for RCEC/RCiEP associations and the added needs for native versus non-native is frustrating. Sean