From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753657AbdKILDE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 06:03:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38026 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753590AbdKILDC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 06:03:02 -0500
Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Eduardo Valentin <eduval@amazon.com>
References: <1510192934-5369-1-git-send-email-wanpeng.li@hotmail.com>
 <1510192934-5369-3-git-send-email-wanpeng.li@hotmail.com>
 <e985d61a-18ef-6dce-e058-c45538ffcdff@redhat.com>
 <CANRm+Cy6rC3+avTuzxHMKtgiyJVPpLXJc0v_YxE-T6kF6kYT9w@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com>
Date: Thu, 9 Nov 2017 12:02:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CANRm+Cy6rC3+avTuzxHMKtgiyJVPpLXJc0v_YxE-T6kF6kYT9w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 09 Nov 2017 11:03:02 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/11/2017 12:01, Wanpeng Li wrote:
> 2017-11-09 18:48 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>> On 09/11/2017 03:02, Wanpeng Li wrote:
>>> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void)
>>>               pv_time_ops.steal_clock = kvm_steal_clock;
>>>       }
>>>
>>> +     pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
>>
>> This needs to be keyed on a new CPUID feature bit.  Eduardo is also
> 
> Will do.
> 
>> adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when
>> PV_DEDICATED is set.
> 
> Why disable PV TLB flush for PV_DEDICATED(qspinlock)?

PV_DEDICATED says pretty much that it is very unlikely to have a
preempted vCPU.  Therefore, the cpumask loop is unnecessary.

Paolo