From: Martin Schiller <ms@dev.tdt.de>
To: Xie He <xie.he.0141@gmail.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 4/6] net/x25: support NETDEV_CHANGE notifier
Date: Tue, 17 Nov 2020 13:30:24 +0100 [thread overview]
Message-ID: <93e2a7226531ce6832241be1c4296b9d@dev.tdt.de> (raw)
In-Reply-To: <CAJht_ENE5fGr-rgOd-5Tk_g5RJibaWBn_ey5Avo-2R2opMGcDA@mail.gmail.com>
On 2020-11-17 12:41, Xie He wrote:
> On Mon, Nov 16, 2020 at 6:00 AM Martin Schiller <ms@dev.tdt.de> wrote:
>>
>> This makes it possible to handle carrier lost and detection.
>> In case of carrier lost, we shutdown layer 3 and flush all sessions.
>>
>> @@ -275,6 +275,19 @@ static int x25_device_event(struct notifier_block
>> *this, unsigned long event,
>> dev->name);
>> x25_link_device_remove(dev);
>> break;
>> + case NETDEV_CHANGE:
>> + pr_debug("X.25: got event NETDEV_CHANGE for
>> device: %s\n",
>> + dev->name);
>> + if (!netif_carrier_ok(dev)) {
>> + pr_debug("X.25: Carrier lost -> set
>> link state down: %s\n",
>> + dev->name);
>> + nb = x25_get_neigh(dev);
>> + if (nb) {
>> + x25_link_terminated(nb);
>> + x25_neigh_put(nb);
>> + }
>> + }
>> + break;
>> }
>> }
>
> I think L2 will notify L3 if the L2 connection is terminated. Is this
> patch necessary?
Hmm... well I guess you're right. Admittedly, these patches were made
about 7 - 8 years ago and I have to keep thinking about them.
But I can't think of any situation where this patch should be necessary
at the moment.
I will drop this patch from the patch-set.
next prev parent reply other threads:[~2020-11-17 12:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 13:55 [PATCH net-next v2 0/6] netdev event handling + neighbour config Martin Schiller
2020-11-16 13:55 ` [PATCH net-next v2 1/6] net/x25: handle additional netdev events Martin Schiller
2020-11-16 13:55 ` [PATCH net-next v2 2/6] net/x25: make neighbour params configurable Martin Schiller
2020-11-16 17:05 ` David Laight
2020-11-16 13:55 ` [PATCH net-next v2 3/6] net/x25: replace x25_kill_by_device with x25_kill_by_neigh Martin Schiller
2020-11-17 19:50 ` Xie He
2020-11-18 8:28 ` Martin Schiller
2020-11-16 13:55 ` [PATCH net-next v2 4/6] net/x25: support NETDEV_CHANGE notifier Martin Schiller
2020-11-17 11:41 ` Xie He
2020-11-17 12:30 ` Martin Schiller [this message]
2020-11-16 13:55 ` [PATCH net-next v2 5/6] net/lapb: support netdev events Martin Schiller
2020-11-16 20:16 ` Xie He
2020-11-17 9:52 ` Martin Schiller
2020-11-17 11:32 ` Xie He
2020-11-17 13:26 ` Martin Schiller
2020-11-17 18:28 ` Xie He
2020-11-18 8:49 ` Martin Schiller
2020-11-18 13:03 ` Xie He
2020-11-18 13:46 ` Xie He
2020-11-18 13:57 ` Martin Schiller
2020-11-16 13:55 ` [PATCH net-next v2 6/6] net/lapb: fix t1 timer handling Martin Schiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e2a7226531ce6832241be1c4296b9d@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).