From: Bastien Nocera <hadess@hadess.net>
To: William Mahon <wmahon@chromium.org>, LKML <linux-kernel@vger.kernel.org>
Cc: William Mahon <wmahon@google.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add mapping for KEY_APP_LAUNCHER
Date: Thu, 17 Feb 2022 11:35:24 +0100 [thread overview]
Message-ID: <93e5dc0bbeb0b44c9b225946b3ab81d3af3a1789.camel@hadess.net> (raw)
In-Reply-To: <20220217053354.1.I3a7746ad05d270161a18334ae06e3b6db1a1d339@changeid>
On Thu, 2022-02-17 at 05:33 +0000, William Mahon wrote:
> The App Launcher key is used to bring up the Launcher menu.
>
> This patch adds a new key definition KEY_APP_LAUNCHER and maps
> 0x0c02a28
Is this a typo? It's not the same format as in your other patch.
KEY_DASHBOARD as used in the Mac keyboard drivers looks like a good
match for KEY_APP_LAUNCHER. If not, it would be good to explain why in
the commit message.
See 437184ae8bd1ef923a40b009e37801deae66ad55 for the KEY_DASHBOARD
addition.
> usage code to this new keycode. Additionally hid-debug is adjusted to
> recognize this new usage code as well.
>
> Signed-off-by: William Mahon <wmahon@google.com>
> ---
>
> drivers/hid/hid-debug.c | 1 +
> drivers/hid/hid-input.c | 2 ++
> include/uapi/linux/input-event-codes.h | 2 ++
> 3 files changed, 5 insertions(+)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 01135713e8f9..36a42ad3b7bc 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -930,6 +930,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_SCREENSAVER] = "ScreenSaver",
> [KEY_VOICECOMMAND] = "VoiceCommand",
> [KEY_EMOJI_PICKER] = "EmojiPicker",
> + [KEY_APP_LAUNCHER] = "AppLauncher",
> [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> [KEY_BRIGHTNESS_MAX] = "BrightnessMax",
> [KEY_BRIGHTNESS_AUTO] = "BrightnessAuto",
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index eccd89b5ea9f..7c89260826b2 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1162,6 +1162,8 @@ static void hidinput_configure_usage(struct
> hid_input *hidinput, struct hid_fiel
>
> case 0x29d:
> map_key_clear(KEY_KBD_LAYOUT_NEXT); break;
>
> + case 0x2a2:
> map_key_clear(KEY_APP_LAUNCHER); break;
> +
> case 0x2c7:
> map_key_clear(KEY_KBDINPUTASSIST_PREV); break;
> case 0x2c8:
> map_key_clear(KEY_KBDINPUTASSIST_NEXT); break;
> case 0x2c9:
> map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP); break;
> diff --git a/include/uapi/linux/input-event-codes.h
> b/include/uapi/linux/input-event-codes.h
> index 311a57f3e01a..fdf43cf14125 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -651,6 +651,8 @@
> #define KEY_DATA 0x277
> #define KEY_ONSCREEN_KEYBOARD 0x278
>
> +#define KEY_APP_LAUNCHER 0x27c
> +
> #define BTN_TRIGGER_HAPPY 0x2c0
> #define BTN_TRIGGER_HAPPY1 0x2c0
> #define BTN_TRIGGER_HAPPY2 0x2c1
next prev parent reply other threads:[~2022-02-17 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 5:33 [PATCH] HID: Add mapping for KEY_APP_LAUNCHER William Mahon
2022-02-17 10:35 ` Bastien Nocera [this message]
2022-02-18 6:48 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e5dc0bbeb0b44c9b225946b3ab81d3af3a1789.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wmahon@chromium.org \
--cc=wmahon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).