From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751671AbeBZSTh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Feb 2018 13:19:37 -0500
Received: from mail-lf0-f45.google.com ([209.85.215.45]:39622 "EHLO
        mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751022AbeBZSTf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Feb 2018 13:19:35 -0500
X-Google-Smtp-Source: AH8x2264v1pVUxzm4kFd04WpeA68Hdz06A2A+hKDBqQbOzX0US70vrDC3jSQFJwiQkLpTipWmg81Pw==
Subject: Re: [PATCH V3 00/19] lightnvm: pblk: implement 2.0 support
To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= <jg@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org,
        =?UTF-8?Q?Javier_Gonz=c3=a1lez?= <javier@cnexlabs.com>
References: <1519651038-16845-1-git-send-email-javier@cnexlabs.com>
From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>
Message-ID: <93f1a727-55bf-ff7c-bc05-70cc9f5f9f27@lightnvm.io>
Date: Mon, 26 Feb 2018 19:19:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1519651038-16845-1-git-send-email-javier@cnexlabs.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/26/2018 02:16 PM, Javier González wrote:
> # Changes since V2:
> 
> Apply Matias' feedback:
>   - Remove generic nvm_id identify structure.
>   - Do not remap capabilities (cap) to media and controlled capabilities
>     (mccap). Instead, add a comment to prevent confusion when
>     crosschecking with 2.0 spec.
>   - Change maxoc and maxocpu defaults from 1 block to the max number of
>     blocks.
>   - Re-implement the generic geometry to use nvm_geo on both device and
>     targets. Maintain nvm_common_geo to make it easier to copy the common
>     part of the geometry (without having to overwrite target-specific
>     fields, which is ugly and error prone). Matias, if you still want to
>     get rid of this, we can do it.

I do, the variables should go directly in nvm_geo. Thanks.