From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FBEC636D3 for ; Tue, 31 Jan 2023 06:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbjAaG4n (ORCPT ); Tue, 31 Jan 2023 01:56:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230428AbjAaG4i (ORCPT ); Tue, 31 Jan 2023 01:56:38 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A367B2748F; Mon, 30 Jan 2023 22:56:36 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 78A7424E1EB; Tue, 31 Jan 2023 14:56:28 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 31 Jan 2023 14:56:28 +0800 Received: from [192.168.125.128] (183.27.97.127) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 31 Jan 2023 14:56:27 +0800 Message-ID: <93f9e7b9-90a7-0c9f-91c2-301a1431b12d@starfivetech.com> Date: Tue, 31 Jan 2023 14:52:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 06/11] clk: starfive: Add StarFive JH7110 Image-Signal-Process clock driver Content-Language: en-US To: Stephen Boyd , Emil Renner Berthing , Krzysztof Kozlowski , Michael Turquette , Philipp Zabel , , CC: Rob Herring , Conor Dooley , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Hal Feng , , References: <20230120024445.244345-1-xingyu.wu@starfivetech.com> <20230120024445.244345-7-xingyu.wu@starfivetech.com> <26437c6f0bda4dd18e16fa1f58013911.sboyd@kernel.org> From: Xingyu Wu In-Reply-To: <26437c6f0bda4dd18e16fa1f58013911.sboyd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.127] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/1/31 8:38, Stephen Boyd wrote: > Quoting Xingyu Wu (2023-01-19 18:44:40) >> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-isp.c b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> new file mode 100644 >> index 000000000000..f9fc94b4c6f8 >> --- /dev/null >> +++ b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> @@ -0,0 +1,218 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * StarFive JH7110 Image-Signal-Process Clock Driver > [...] >> + >> +static int jh7110_isp_top_crg_enable(struct isp_top_crg *top) >> +{ >> + int ret; >> + >> + ret = clk_bulk_prepare_enable(top->top_clks_num, top->top_clks); >> + if (ret) >> + return ret; >> + >> + return reset_control_deassert(top->top_rsts); >> +} > > This needs to be undone on driver remove. Will add in next patch. Best regards, Xingyu Wu