From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <rogerq@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add documentation for AM62 USB Wrapper module
Date: Thu, 24 Mar 2022 12:07:13 +0100 [thread overview]
Message-ID: <93fe6a41-3b59-2fbc-6f95-833f337815ee@kernel.org> (raw)
In-Reply-To: <20220324073425.18607-2-a-govindraju@ti.com>
On 24/03/2022 08:34, Aswath Govindraju wrote:
> Add bindings for the TI's AM62 wrapper module for the Synopsys USBSS-DRD
> controller.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> Changes since v1:
> - made correction in grammer of clocks property description
> and added maxItems in the interrupts property based on comments
> received from Roger
> - corrected the title, fixed the description of
> ti,syscon-phy-pll-refclk, added pattern properties and child node
> in the example based on the comments from Krzysztof.
>
> .../devicetree/bindings/usb/ti,am62-usb.yaml | 117 ++++++++++++++++++
> 1 file changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> new file mode 100644
> index 000000000000..452bfdc6fb09
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ti,am62-usb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI's AM62 wrapper module for the Synopsys USBSS-DRD controller
> +
> +maintainers:
> + - Aswath Govindraju <a-govindraju@ti.com>
> +
> +properties:
> + compatible:
> + const: ti,am62-usb
> +
> + reg:
> + maxItems: 1
> +
> + ranges: true
> +
> + power-domains:
> + description:
> + PM domain provider node and an args specifier containing
> + the USB ISO device id value. See,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> + maxItems: 1
> +
> + clocks:
> + description: Clock phandle to usb2_refclk
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ref
> +
> + id-gpio:
> + description:
> + GPIO to be used as ID pin
> + maxItems: 1
I have doubts about this. If you USB controller handles the ID pin, then
probably this should be moved to usb-connector.yaml. I did not see
id-gpio in any other USB controller blocks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-24 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 7:34 [PATCH v2 0/2] AM62: Add support for AM62 USB wrapper driver Aswath Govindraju
2022-03-24 7:34 ` [PATCH v2 1/2] dt-bindings: usb: Add documentation for AM62 USB Wrapper module Aswath Govindraju
2022-03-24 11:07 ` Krzysztof Kozlowski [this message]
2022-03-24 11:40 ` Aswath Govindraju
2022-03-24 11:53 ` Krzysztof Kozlowski
2022-04-01 0:20 ` Rob Herring
2022-04-01 5:04 ` Aswath Govindraju
2022-04-01 7:49 ` Krzysztof Kozlowski
2022-04-01 8:05 ` Aswath Govindraju
2022-03-24 7:34 ` [PATCH v2 2/2] drivers: usb: dwc3: Add AM62 USB wrapper driver Aswath Govindraju
2022-04-07 5:32 ` [PATCH v2 0/2] AM62: Add support for " Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93fe6a41-3b59-2fbc-6f95-833f337815ee@kernel.org \
--to=krzk@kernel.org \
--cc=a-govindraju@ti.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).