From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, David Sterba <dsterba@suse.cz>,
Eric Biggers <ebiggers@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 0/2] pipe: Fixes [ver #2]
Date: Wed, 11 Dec 2019 20:55:31 +0000 [thread overview]
Message-ID: <9417.1576097731@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wjeG0q1vgzu4iJhW5juPkTsjTYmiqiMUYAebWW+0bam6w@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> DavidH, give these a look:
>
> 85190d15f4ea pipe: don't use 'pipe_wait() for basic pipe IO
> a28c8b9db8a1 pipe: remove 'waiting_writers' merging logic
> f467a6a66419 pipe: fix and clarify pipe read wakeup logic
> 1b6b26ae7053 pipe: fix and clarify pipe write wakeup logic
> ad910e36da4c pipe: fix poll/select race introduced by the pipe rework
>
> the top two of which are purely "I'm fed up looking at this code, this
> needs to go" kind of changes.
They look reasonable.
Is it worth reverting:
commit f94df9890e98f2090c6a8d70c795134863b70201
Add wake_up_interruptible_sync_poll_locked()
since you changed the code that was calling that new function and so it's no
longer called?
David
next prev parent reply other threads:[~2019-12-11 20:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 22:30 [PATCH 0/2] pipe: Fixes [ver #2] David Howells
2019-12-05 22:30 ` [PATCH 1/2] pipe: Remove assertion from pipe_poll() " David Howells
2019-12-05 22:30 ` [PATCH 2/2] pipe: Fix missing mask update after pipe_wait() " David Howells
2019-12-05 23:58 ` Linus Torvalds
2019-12-06 13:56 ` [PATCH 0/2] pipe: Fixes " David Sterba
2019-12-06 17:09 ` Linus Torvalds
2019-12-06 17:42 ` Linus Torvalds
2019-12-06 18:59 ` Linus Torvalds
2019-12-07 21:31 ` Akemi Yagi
2019-12-08 16:45 ` Akemi Yagi
2019-12-08 18:04 ` Linus Torvalds
2019-12-09 3:07 ` Linus Torvalds
2019-12-06 20:28 ` Linus Torvalds
2019-12-06 21:04 ` Linus Torvalds
2019-12-07 3:50 ` Linus Torvalds
2019-12-07 4:01 ` Linus Torvalds
2019-12-07 22:47 ` Linus Torvalds
2019-12-09 9:53 ` Vincent Guittot
2019-12-09 17:48 ` Linus Torvalds
2019-12-09 17:57 ` Akemi Yagi
2019-12-09 18:18 ` Linus Torvalds
2019-12-09 18:24 ` Linus Torvalds
2019-12-18 20:59 ` Josh Triplett
2019-12-10 2:58 ` DJ Delorie
2019-12-10 14:38 ` Vincent Guittot
2019-12-10 17:39 ` Linus Torvalds
2019-12-11 18:09 ` DJ Delorie
2019-12-11 18:59 ` Linus Torvalds
2019-12-12 10:18 ` Konstantin Khlebnikov
2019-12-18 22:51 ` Linus Torvalds
2019-12-19 0:03 ` Josh Triplett
2019-12-19 0:14 ` Josh Triplett
2019-12-19 0:51 ` Linus Torvalds
2019-12-19 0:54 ` Linus Torvalds
2019-12-19 7:56 ` David Howells
2019-12-19 16:35 ` Linus Torvalds
2019-12-11 20:55 ` David Howells [this message]
2019-12-12 1:28 ` Linus Torvalds
2019-12-12 7:34 ` David Howells
2019-12-09 14:55 ` David Sterba
2019-12-06 21:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9417.1576097731@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dsterba@suse.cz \
--cc=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).