From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41305C433F5 for ; Fri, 10 Sep 2021 23:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 168BF6121D for ; Fri, 10 Sep 2021 23:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234882AbhIJXwK (ORCPT ); Fri, 10 Sep 2021 19:52:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234787AbhIJXwJ (ORCPT ); Fri, 10 Sep 2021 19:52:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C14761215; Fri, 10 Sep 2021 23:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631317857; bh=uIpzXfyi8+fV+u3rmhdW4lpuq9BRwztl6U+ksNKr5PI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PIBWcXKzrLpgOJluRe/nYh34CXuRmxKG27Dbkve6wm+0eJ7x7H6z1IbAhgZArFREO 1az18KO+TyHJppslmxXpR0LoXiXckEnto/CeJUadea/vLrq5JZXOn6QE9u/9gvPh3l BzFIULLWf1jk/uYBj1MjA2kQ+Z1d8xjnPxe4YPNw74JLvUyQzYkn2Lr+sf4eFvxeSh /IuDhsR1qGJ67svnFkpkL4xyAqunt6zgwVkeAUJW9U61xopJL6l2khHnwWL/kBEz06 OpdpNLK0eu9nvb5P/G60oOIskv+VfLNCD8sMEtGb10Nw/LMYD/E2fhoXFATagx+e79 InTBhzg2s9w6A== Subject: Re: [PATCH 10/10] vmlinux.lds.h: remove old check for GCC 4.9 To: Nick Desaulniers , Andrew Morton Cc: Linus Torvalds , Rasmus Villemoes , Masahiro Yamada , Joe Perches , Arnd Bergmann , Stephen Rothwell , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Peter Zijlstra References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-11-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: <9433c702-ecf2-4197-2456-59857d38538d@kernel.org> Date: Fri, 10 Sep 2021 16:50:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910234047.1019925-11-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/2021 4:40 PM, Nick Desaulniers wrote: > Now that GCC 5.1 is the minimally supported version of GCC, we can > effectively revert > > commit 85c2ce9104eb ("sched, vmlinux.lds: Increase STRUCT_ALIGNMENT to > 64 bytes for GCC-4.9") > > Cc: Peter Zijlstra > Signed-off-by: Nick Desaulniers > --- > include/asm-generic/vmlinux.lds.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index aa50bf2959fe..f2984af2b85b 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -116,11 +116,7 @@ > * GCC 4.5 and later have a 32 bytes section alignment for structures. > * Except GCC 4.9, that feels the need to align on 64 bytes. Comment should be adjusted. > */ > -#if __GNUC__ == 4 && __GNUC_MINOR__ == 9 > -#define STRUCT_ALIGNMENT 64 > -#else > #define STRUCT_ALIGNMENT 32 > -#endif > #define STRUCT_ALIGN() . = ALIGN(STRUCT_ALIGNMENT) > > /* >