Re: [PATCH v2] iov_iter: Fix build error without CONFIG_CRYPTO

From: YueHaibing <yuehaibing@huawei.com>
To: <davem@davemloft.net>, <viro@zeniv.linux.org.uk>,
	<willemb@google.com>, <edumazet@google.com>, <fw@strlen.de>,
	<sagi@lightbitslabs.com>, <hch@lst.de>, <pabeni@redhat.com>,
	<pctammela@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] iov_iter: Fix build error without CONFIG_CRYPTO
Date: Thu, 4 Apr 2019 10:40:45 +0800	[thread overview]
Message-ID: <944510e2-798d-b0aa-407d-242c7f0c11da@huawei.com> (raw)
In-Reply-To: <20190404023114.30304-1-yuehaibing@huawei.com>

Pls ignore this, sorry.

On 2019/4/4 10:31, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> If CONFIG_CRYPTO is not set or set to m,
> gcc building warn this:
> 
> lib/iov_iter.o: In function `hash_and_copy_to_iter':
> iov_iter.c:(.text+0x9129): undefined reference to `crypto_stats_get'
> iov_iter.c:(.text+0x9152): undefined reference to `crypto_stats_ahash_update'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: d05f443554b3 ("iov_iter: introduce hash_and_copy_to_iter helper")
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> ---
>  lib/iov_iter.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index 50e77ec..f74fa83 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -1531,6 +1531,7 @@ EXPORT_SYMBOL(csum_and_copy_to_iter);
>  size_t hash_and_copy_to_iter(const void *addr, size_t bytes, void *hashp,
>  		struct iov_iter *i)
>  {
> +#ifdef CONFIG_CRYPTO
>  	struct ahash_request *hash = hashp;
>  	struct scatterlist sg;
>  	size_t copied;
> @@ -1540,6 +1541,9 @@ size_t hash_and_copy_to_iter(const void *addr, size_t bytes, void *hashp,
>  	ahash_request_set_crypt(hash, &sg, NULL, copied);
>  	crypto_ahash_update(hash);
>  	return copied;
> +#else
> +	return 0;
> +#endif
>  }
>  EXPORT_SYMBOL(hash_and_copy_to_iter);
>  
> 