linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>,
	jejb@kernel.org, hch@infradead.org
Cc: linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com,
	linux-kernel@vger.kernel.org, christopher.owens@broadcom.com,
	kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V5 00/11] megaraid_sas: Updates for scsi-next
Date: Thu, 15 Dec 2016 16:50:11 +0100	[thread overview]
Message-ID: <944e4acd-6a9e-1a3f-debf-f6634e365ad6@redhat.com> (raw)
In-Reply-To: <1481753588-101811-1-git-send-email-sasikumar.pc@broadcom.com>

On 14.12.2016 23:12, Sasikumar Chandrasekaran wrote:
> Sasikumar Chandrasekaran (11):
>   megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid
>     Controllers
>   megaraid_sas: 128 MSIX Support
>   megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid
>     Controllers
>   megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and
>     IO Coalescing
>   megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID
>     1/10 Writes
>   megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid
>     Controllers
>   megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers
>     Capabilities
>   megaraid_sas: Enable or Disable Fast path based on the PCI Threshold
>     Bandwidth
>   megaraid_sas: ldio_outstanding variable is not decremented in
>     completion path
>   megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid
>     Controllers
>   megaraid_sas: driver version upgrade
>
>  drivers/scsi/megaraid/megaraid_sas.h        | 139 ++++--
>  drivers/scsi/megaraid/megaraid_sas_base.c   | 233 +++++++--
>  drivers/scsi/megaraid/megaraid_sas_fp.c     | 293 +++++++++--
>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 742 +++++++++++++++++++++++-----
>  drivers/scsi/megaraid/megaraid_sas_fusion.h | 364 ++++++++++++--
>  5 files changed, 1495 insertions(+), 276 deletions(-)
>
Sasi,
when I told you that you can in certain situations ignore the 80 chars per line limit
(and in specific cases it is even expected) it was not a free pass for you to
create the extremely long lines like you did.
Also when I complained in V1 about the 
ERROR: DOS line endings
#80: FILE: drivers/scsi/megaraid/megaraid_sas.h:59:
+#define PCI_DEVICE_ID_LSI_MECTOR^I^I    0x00D4^M$
I was hoping you'd have removed these and didn't check any more - but they are still there
(Easy way how to avoid these errors is to use any linux editor, when you edit the patches.)
Some of those issues may be fixed when the patch is added to a git tree, so I'll
leave final decision on our maintainer and try to not comment any more on this kind of issues.

Cheers,
Tomas

      parent reply	other threads:[~2016-12-15 15:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 22:12 [PATCH V5 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
2016-12-14 22:12 ` [PATCH V5 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-14 22:12 ` [PATCH V5 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
2016-12-15 14:38   ` Tomas Henzl
2016-12-14 22:13 ` [PATCH V5 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-15 15:04   ` Tomas Henzl
2016-12-14 22:13 ` [PATCH V5 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
2016-12-15 15:13   ` Tomas Henzl
2016-12-14 22:13 ` [PATCH V5 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-14 22:13 ` [PATCH V5 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
2016-12-15 15:50 ` Tomas Henzl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=944e4acd-6a9e-1a3f-debf-f6634e365ad6@redhat.com \
    --to=thenzl@redhat.com \
    --cc=Sathya.Prakash@broadcom.com \
    --cc=christopher.owens@broadcom.com \
    --cc=hch@infradead.org \
    --cc=jejb@kernel.org \
    --cc=kiran-kumar.kasturi@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sasikumar.pc@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).