From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uts: Don't randomize "struct uts_namespace".
Date: Sat, 7 Jul 2018 08:35:28 +0900 [thread overview]
Message-ID: <945be212-8e82-9dd8-930f-4e5c11dcae77@i-love.sakura.ne.jp> (raw)
In-Reply-To: <CAGXu5jKrM_3ymnmcJ+AE1A3uVPDJykRj0z5B8sDoxM6zUnX-Rg@mail.gmail.com>
I'm waiting for response from makedumpfile developers.
But makedumpfile is a tool for saving kernel crash dump.
If makedumpfile cannot work, we cannot use kernel crash dump.
On 2018/07/07 8:19, Kees Cook wrote:
> On Fri, Jul 6, 2018 at 9:11 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Fri, Jul 6, 2018 at 3:07 AM Tetsuo Handa
>> <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>>
>>> I noticed that makedumpfile utility is failing to check kernel version, for
>>> it depends on offset of "struct uts_namespace"->name being sizeof(int).
>>
>> For something like this, we fix makedumpfile instead. This is not a
>> "user program" using system calls etc, this is something that delves
>> into the kernel dump and tries to make sense of it.
>>
>> Where is the makedumpfile source code? What is it trying to do, and why?
>>
>> One option is to just say "hey, you can't make much sense of a
>> randomized kernel dump anyway, so don't even try".
>
> I would second this -- trying to deal with a randomized layout kernel
> dump is going to be much worse than just looking at uts_namespace. :)
>
> -Kees
>
next prev parent reply other threads:[~2018-07-06 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 10:07 [PATCH] uts: Don't randomize "struct uts_namespace" Tetsuo Handa
2018-07-06 16:11 ` Linus Torvalds
2018-07-06 23:10 ` Tetsuo Handa
2018-07-11 16:31 ` Kazuhito Hagio
2018-07-06 23:19 ` Kees Cook
2018-07-06 23:35 ` Tetsuo Handa [this message]
2018-07-07 0:55 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945be212-8e82-9dd8-930f-4e5c11dcae77@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).