From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762282AbdALANt (ORCPT ); Wed, 11 Jan 2017 19:13:49 -0500 Received: from mleia.com ([178.79.152.223]:34692 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753140AbdALANr (ORCPT ); Wed, 11 Jan 2017 19:13:47 -0500 Subject: Re: [PATCH 44/62] watchdog: pnx4008_wdt: Convert to use device managed functions To: Guenter Roeck , Wim Van Sebroeck References: <1484091325-9199-1-git-send-email-linux@roeck-us.net> <1484095516-12720-1-git-send-email-linux@roeck-us.net> <1484095516-12720-14-git-send-email-linux@roeck-us.net> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Sylvain Lemieux , linux-arm-kernel@lists.infradead.org From: Vladimir Zapolskiy Message-ID: <94652a06-cd97-5ad2-a40b-fca3a4a33ccb@mleia.com> Date: Thu, 12 Jan 2017 02:13:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484095516-12720-14-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20170112_001346_307987_52AFD667 X-CRM114-Status: GOOD ( 13.82 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On 01/11/2017 02:44 AM, Guenter Roeck wrote: > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts used > to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Use devm_add_action_or_reset() for calls to clk_disable_unprepare > - Replace 'goto l; ... l: return e;' with 'return e;' > - Drop remove function > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Vladimir Zapolskiy Acked-by: Vladimir Zapolskiy Thank you for the cleanup. > Cc: Sylvain Lemieux > Signed-off-by: Guenter Roeck -- With best wishes, Vladimir