From: Joao Martins <firstname.lastname@example.org>
To: Sean Christopherson <email@example.com>
Cc: "Liran Alon" <firstname.lastname@example.org>,
"Paolo Bonzini" <email@example.com>,
"Radim Krčmář" <firstname.lastname@example.org>,
"Vitaly Kuznetsov" <email@example.com>,
"Wanpeng Li" <firstname.lastname@example.org>,
"Jim Mattson" <email@example.com>,
"Joerg Roedel" <firstname.lastname@example.org>,
"Jag Raman" <email@example.com>
Subject: Re: [PATCH v1 2/3] KVM: VMX: Do not change PID.NDST when loading a blocked vCPU
Date: Mon, 11 Nov 2019 17:27:57 +0000 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 11/11/19 3:53 PM, Sean Christopherson wrote:
> On Mon, Nov 11, 2019 at 04:59:20PM +0200, Liran Alon wrote:
>>> On 11 Nov 2019, at 16:56, Joao Martins <email@example.com> wrote:
>>> On 11/11/19 2:50 PM, Paolo Bonzini wrote:
>>>> On 11/11/19 15:48, Joao Martins wrote:
>>>>>>> Fixes: c112b5f50232 ("KVM: x86: Recompute PID.ON when clearing PID.SN")
>>>>>>> Signed-off-by: Joao Martins <firstname.lastname@example.org>
>>>>>>> Signed-off-by: Liran Alon <email@example.com>
>>>>>> Something wrong in the SoB line?
>>>>> I can't spot any mistake; at least it looks chained correctly for me. What's the
>>>>> issue you see with the Sob line?
>>>> Liran's line after yours is confusing. Did he help with the analysis or
>>>> anything like that?
>>> He was initially reviewing my patches, but then helped improving the problem
>>> description in the commit messages so felt correct to give credit.
>> I think proper action is to just remove me from the SoB line.
> Use Co-developed-by to attribute multiple authors. Note, the SoB ordering
> should show the chronological history of the patch when possible, e.g. the
> person sending the patch should always have their SoB last.
> Documentation/process/submitting-patches.rst and
> Documentation/process/5.Posting.rst have more details.
The Sob chain on the first two patches were broken (regardless of any use of
Co-developed-by). Fixed it up on v2, alongside the rest of the comments.
next prev parent reply other threads:[~2019-11-11 17:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:55 [PATCH v1 0/3] KVM: VMX: Posted Interrupts fixes Joao Martins
2019-11-06 17:56 ` [PATCH v1 1/3] KVM: VMX: Consider PID.PIR to determine if vCPU has pending interrupts Joao Martins
2019-11-07 16:00 ` Jag Raman
2019-11-11 14:46 ` Paolo Bonzini
2019-11-11 14:59 ` Joao Martins
2019-11-11 15:58 ` Paolo Bonzini
2019-11-06 17:56 ` [PATCH v1 2/3] KVM: VMX: Do not change PID.NDST when loading a blocked vCPU Joao Martins
2019-11-06 21:54 ` Joao Martins
2019-11-11 14:39 ` Paolo Bonzini
2019-11-11 14:48 ` Joao Martins
2019-11-11 14:50 ` Paolo Bonzini
2019-11-11 14:56 ` Joao Martins
2019-11-11 14:59 ` Liran Alon
2019-11-11 15:53 ` Sean Christopherson
2019-11-11 17:27 ` Joao Martins [this message]
2019-11-06 17:56 ` [PATCH v1 3/3] KVM: VMX: Introduce pi_is_pir_empty() helper Joao Martins
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).