From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932806AbcE0IcV (ORCPT ); Fri, 27 May 2016 04:32:21 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:57973 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbcE0IcR (ORCPT ); Fri, 27 May 2016 04:32:17 -0400 From: Arnd Bergmann To: maitysanchayan@gmail.com Cc: Rob Herring , Shawn Guo , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Date: Fri, 27 May 2016 10:31:55 +0200 Message-ID: <9495361.v6aft1QR0M@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160527063301.GB1554@Sanchayan-Arch.localdomain> References: <20160527063301.GB1554@Sanchayan-Arch.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:w3tMfArhvvukWL4Y774HKMKND+ueOyyyNmpinS9Qhh/w8srqefl ftYm3pgl0sBi1weCWvQcRROsgXoAQ1jWlxhw/4FqIbfoK1URLrrv4/Vhwbqh32Qg4Wdzi+L 4XTZbz27xm5SxD7pdMmBVo/TIom9gPPc+ZF99DI6L+iX8P50ACoDlBwCJlk1x/EpDhwN57r 1fwJOQhLjN2PIKM61Uqiw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Qn+CU43a1JE=:nq+5w5TbH6MeGsrZpEpgWy oRqUJflGDijHaMK/agqnq8hiE/R4nzHguDbz4ynYkh5Uf6Bi7cgez/7/QEvLV6y6LCyGZAnMK 8l36yn2W5G6S+bJ/T+3A39HtkO2BdYzZTIplz8dyjQwy2c/Sra4Mb4/oM48EwbRUcfDiWnfk5 pB1GGNX13e0k63P5gTv6nKRTYA2y5wjU23YR99Fbinw/jxbU1rkx/vqRtHTBHmRC2+bpUxlR4 W9eBtjlsQffi4GVExGlzri1NEqHAFa2UKdyePvBjLGQeyHg4xc+8iahih/6oGZi/oqrOSQ2e0 e0gfmrN0smg1DGNnhU5mcwX5+nf7Q5WxJrAsoefADmGWSi53uKzTuAqiQs4wQqjD8Mv180btw 2MWbRLocghvLX6W1+5pw1Ej6BpmYcEQLDLACnD8OzR76Ai++Xq+avOMpH1hCG20qsLeDO/BdK 0quibPsGTXKEWUI+IM4Xcp05ZesSdIB4BPES8AJ7TD4n6rD6qxmamMIDC55EAmtu4yErQ4XxN dY0CRFeUT+0OKrEdzacM39fISd553HfT6rMqde9MHtSZVfhLVzFBjoquIf3BSSGdchzIVt2Ly e6+5+goOT019VLxXAM01b9sSTRPCmSXf6BiTsGxJ97bvvPIBzLB2/TubecwujAcyHVtGpL2P3 4UoY5mshc/BeSEKhL/2tyJpGNvgwa1PTZbRgl+cLQoPw++0oPsAzci4rxiQLcxNcUPBvnwjZI H1CVkeDLBTs1AYsb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 27, 2016 12:03:01 PM CEST maitysanchayan@gmail.com wrote: > > So if I understand correctly, the binding at the SoC level is fine. > Keeping that but removing the additional made-up properties, viz. below > > rom-revision: phandle to the on-chip ROM node > mscm: phandle to the MSCM CPU configuration node > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1 > nvmem-cell-names: should contain string names "cfg0" and "cfg1" > > would be fine? > > We would have something similar to here > http://www.spinics.net/lists/devicetree/msg80655.html > > but now with the DT binding under SoC bus. > You look up the OTP device as a syscon here, which seems odd since there is already an nvmem driver for it. Shouldn't you use the nvmem API for that? Arnd