From: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Reddy, Sreekanth" <Sreekanth.Reddy@avagotech.com>
Cc: "jejb@kernel.org" <jejb@kernel.org>,
"JBottomley@Parallels.com" <JBottomley@Parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Sathya.Prakash@avagotech.com" <Sathya.Prakash@avagotech.com>,
"Nagalakshmi.Nandigama@avagotech.com"
<Nagalakshmi.Nandigama@avagotech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>
Subject: RE: [RESEND][PATCH 06/10][SCSI]mpt2sas: For >2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive
Date: Sun, 13 Jul 2014 17:02:21 +0000 [thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B402958BA02C2@G9W0745.americas.hpqcorp.net> (raw)
In-Reply-To: <yq1oawtxoqv.fsf@sermon.lab.mkp.net>
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Martin K. Petersen
...
> Also, this is not touched by the patch, but you're then doing:
>
> (*(__be32 *)(&cdb_ptr[i])) = cpu_to_be32(p_lba);
>
> What if this is a 6-byte READ/WRITE command? You'll end up exceeding the
> size of the LBA field.
All this is inside:
if (cdb0 == READ_16 || cdb0 == READ_10 ||
cdb0 == WRITE_16 || cdb0 == WRITE_10) {
so READ_6 and WRITE_6 and all their oddities are not a problem here.
prev parent reply other threads:[~2014-07-13 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 10:34 [RESEND][PATCH 06/10][SCSI]mpt2sas: For >2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive Reddy, Sreekanth
2014-07-13 15:27 ` Martin K. Petersen
2014-07-13 17:02 ` Elliott, Robert (Server Storage) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94D0CD8314A33A4D9D801C0FE68B402958BA02C2@G9W0745.americas.hpqcorp.net \
--to=elliott@hp.com \
--cc=JBottomley@Parallels.com \
--cc=Nagalakshmi.Nandigama@avagotech.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=Sreekanth.Reddy@avagotech.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).