From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753723AbbFXPQk (ORCPT ); Wed, 24 Jun 2015 11:16:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:32844 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752660AbbFXPQb (ORCPT ); Wed, 24 Jun 2015 11:16:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,672,1427785200"; d="scan'208";a="513571109" From: "Moore, Robert" To: SF Markus Elfring , Len Brown , "Zheng, Lv" , "Wysocki, Rafael J" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" CC: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall Subject: RE: [PATCH] ACPICA: Delete an unnecessary check before the function call "acpi_ds_delete_walk_state" Thread-Topic: [PATCH] ACPICA: Delete an unnecessary check before the function call "acpi_ds_delete_walk_state" Thread-Index: AQHQrnNbu6In+qKbE0i8PjXWAa/+y527xIfg Date: Wed, 24 Jun 2015 15:16:25 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D306826@ORSMSX112.amr.corp.intel.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558A9864.2020608@users.sourceforge.net> In-Reply-To: <558A9864.2020608@users.sourceforge.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5OFGi40018088 Got it, thanks. > -----Original Message----- > From: SF Markus Elfring [mailto:elfring@users.sourceforge.net] > Sent: Wednesday, June 24, 2015 4:46 AM > To: Len Brown; Zheng, Lv; Wysocki, Rafael J; Moore, Robert; linux- > acpi@vger.kernel.org; devel@acpica.org > Cc: LKML; kernel-janitors@vger.kernel.org; Julia Lawall > Subject: [PATCH] ACPICA: Delete an unnecessary check before the function > call "acpi_ds_delete_walk_state" > > From: Markus Elfring > Date: Wed, 24 Jun 2015 13:33:47 +0200 > > The acpi_ds_delete_walk_state() function tests whether its argument is > NULL and then returns immediately. Thus the test around the call is not > needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/acpi/acpica/dsmethod.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/acpi/acpica/dsmethod.c > b/drivers/acpi/acpica/dsmethod.c index 85bb951..188b254 100644 > --- a/drivers/acpi/acpica/dsmethod.c > +++ b/drivers/acpi/acpica/dsmethod.c > @@ -574,10 +574,7 @@ cleanup: > /* On error, we must terminate the method properly */ > > acpi_ds_terminate_control_method(obj_desc, next_walk_state); > - if (next_walk_state) { > - acpi_ds_delete_walk_state(next_walk_state); > - } > - > + acpi_ds_delete_walk_state(next_walk_state); > return_ACPI_STATUS(status); > } > > -- > 2.4.4 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I