From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755322AbcLSVpr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Dec 2016 16:45:47 -0500
Received: from mga04.intel.com ([192.55.52.120]:41149 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753160AbcLSVpq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Dec 2016 16:45:46 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,375,1477983600"; 
   d="scan'208";a="914151092"
From: "Moore, Robert" <robert.moore@intel.com>
To: Kees Cook <keescook@chromium.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Zheng, Lv" <lv.zheng@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        "Len Brown" <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Emese Revfy <re.emese@gmail.com>,
        "devel@acpica.org" <devel@acpica.org>
Subject: RE: [PATCH] acpi: Fix format string type mistakes
Thread-Topic: [PATCH] acpi: Fix format string type mistakes
Thread-Index: AQHSV+aWolzwXoD37UuP26MO5NgzPqELsAqAgAAHvgCABBqa8A==
Date: Mon, 19 Dec 2016 21:45:44 +0000
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E547D9A@ORSMSX110.amr.corp.intel.com>
References: <20161216215137.GA96800@beast>
 <CAJZ5v0h-xUXNHgr5x4ZYRAvsUZDip65aYCPVPeZ3E9=djcpQnA@mail.gmail.com>
 <CAGXu5jKc35OzaPCR-f34THEkmE4ZbPP-cW2BVFzTgPYVmT_5dw@mail.gmail.com>
In-Reply-To: <CAGXu5jKc35OzaPCR-f34THEkmE4ZbPP-cW2BVFzTgPYVmT_5dw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.139]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBJLjtSm024885



> -----Original Message-----
> From: keescook@google.com [mailto:keescook@google.com] On Behalf Of Kees
> Cook
> Sent: Friday, December 16, 2016 3:04 PM
> To: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Moore, Robert <robert.moore@intel.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Zheng, Lv <lv.zheng@intel.com>; Wysocki,
> Rafael J <rafael.j.wysocki@intel.com>; Len Brown <lenb@kernel.org>; ACPI
> Devel Maling List <linux-acpi@vger.kernel.org>; Emese Revfy
> <re.emese@gmail.com>; devel@acpica.org
> Subject: Re: [PATCH] acpi: Fix format string type mistakes
> 
> On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <rafael@kernel.org>
> wrote:
> > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@chromium.org>
> wrote:
> >> From: Emese Revfy <re.emese@gmail.com>
> >>
> >> This adds the missing __printf attribute which allows compile time
> >> format string checking (and will be used by the coming initify gcc
> >> plugin). Additionally, this fixes the warnings exposed by the
> attribute.
> >>
> >> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> >> [kees: split scsi/acpi, merged attr and fix, new commit messages]
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >
> > This modifies code that we get from an external projiect (ACPICA) and
> > the bugs should be fixed in there in the first place.
> 
> Who should get CCed?
> 
> > Moreover, I'm not sure if adding __printf in acpiosxf.h is a good
> idea.
> 
> Why not? This is going to be needed by the initify plugin to do correct
> detection of what's being passed around to functions...
> 

[Moore, Robert] It's compiler-dependent.

> -Kees
> 
> --
> Kees Cook
> Nexus Security