From: "Moore, Robert" <robert.moore@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Vasyl Gomonovych <gomonovych@gmail.com>
Cc: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Schmauss, Erik" <erik.schmauss@intel.com>
Subject: RE: [PATCH] ACPICA: Fix indentation
Date: Fri, 8 Dec 2017 21:13:15 +0000 [thread overview]
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B74FA783@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <CAJZ5v0hgt8MLkxSHeN1A49p4g6VCr-r8x7RGun9eVmtx0PZKgg@mail.gmail.com>
This type of thing more often than not is caused by running the code through indent (lindent).
Original ACPICA code:
ACPI_FUNCTION_NAME (ExDumpOperand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT))
{
return;
}
Raw "linuxized" code:
ACPI_FUNCTION_NAME (ex_dump_operand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) {
return;
}
> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych@gmail.com>
> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> Len Brown <lenb@kernel.org>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; devel@acpica.org; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Schmauss, Erik <erik.schmauss@intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
>
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
>
> This is ACPICA code, so changes like this should go in via the upstream.
>
> Erik may want to pick this up, however.
>
> > ---
> > drivers/acpi/acpica/exdump.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> > ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > - /* Check if debug output enabled */
> > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > + /* Check if debug output enabled */
> > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > return;
> > }
> >
> > --
next prev parent reply other threads:[~2017-12-08 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 16:29 [PATCH] ACPICA: Fix indentation Vasyl Gomonovych
2017-12-08 17:06 ` Rafael J. Wysocki
2017-12-08 21:13 ` Moore, Robert [this message]
2017-12-13 21:53 ` Schmauss, Erik
2017-12-13 22:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94F2FBAB4432B54E8AACC7DFDE6C92E3B74FA783@ORSMSX110.amr.corp.intel.com \
--to=robert.moore@intel.com \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=gomonovych@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).