From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7B2C31E5D for ; Tue, 18 Jun 2019 20:31:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A09206E0 for ; Tue, 18 Jun 2019 20:31:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730640AbfFRUby convert rfc822-to-8bit (ORCPT ); Tue, 18 Jun 2019 16:31:54 -0400 Received: from mga12.intel.com ([192.55.52.136]:54755 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729961AbfFRUby (ORCPT ); Tue, 18 Jun 2019 16:31:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 13:31:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,390,1557212400"; d="scan'208";a="161848074" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga007.fm.intel.com with ESMTP; 18 Jun 2019 13:31:53 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 13:31:52 -0700 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.92]) by ORSMSX162.amr.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 13:31:52 -0700 From: "Moore, Robert" To: Nikolaus Voss CC: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , "Schmauss, Erik" , Jacek Anaszewski , Pavel Machek , Dan Murphy , Thierry Reding , ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , "linux-leds@vger.kernel.org" , Linux PWM List , Linux Kernel Mailing List Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads Thread-Topic: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads Thread-Index: AQHVIPn/qqDB5Bv4z0aSsleXlAnDw6abVhaAgAADpwD///G0sIAEkokAgACES6CAAT+dAIAANdnAgAALWnCAAAJ3oIAAAgmg Date: Tue, 18 Jun 2019 20:31:52 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95FB0BA@ORSMSX110.amr.corp.intel.com> References: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95EFB26@ORSMSX110.amr.corp.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E3B95F9EC6@ORSMSX110.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWYzNDM4MzQtOGVmNS00ZTRiLWJkZTktZDExNTM1YTg5ZDk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialA3Y1d2Z3ZkMnZ2VUpzaXc3aDBTaWxGMFFmdEE4QUdvRCtYSHUrWWozN0g3cnRLckZMc1hwbEdXZkdmditHZiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Moore, Robert > Sent: Tuesday, June 18, 2019 1:25 PM > To: 'Nikolaus Voss' > Cc: 'Rafael J. Wysocki' ; 'Rafael J. Wysocki' > ; 'Len Brown' ; Schmauss, Erik > ; 'Jacek Anaszewski' > ; 'Pavel Machek' ; 'Dan > Murphy' ; 'Thierry Reding' ; > 'ACPI Devel Maling List' ; 'open list:ACPI > COMPONENT ARCHITECTURE (ACPICA)' ; 'linux- > leds@vger.kernel.org' ; 'Linux PWM List' > ; 'Linux Kernel Mailing List' kernel@vger.kernel.org> > Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table > loads > > If it is in fact the AcpiLoadTable interface that is incorrect, that of > course is different. I'll check that out next. > [Moore, Robert] Yes, this is the issue, not specifically the Load() operator, but the AcpiLoadTable interface only. > > > -----Original Message----- > > From: Moore, Robert > > Sent: Tuesday, June 18, 2019 1:23 PM > > To: 'Nikolaus Voss' > > Cc: 'Rafael J. Wysocki' ; 'Rafael J. Wysocki' > > ; 'Len Brown' ; Schmauss, Erik > > ; 'Jacek Anaszewski' > > ; 'Pavel Machek' ; 'Dan > > Murphy' ; 'Thierry Reding' ; > > 'ACPI Devel Maling List' ; 'open list:ACPI > > COMPONENT ARCHITECTURE (ACPICA)' ; 'linux- > > leds@vger.kernel.org' ; 'Linux PWM List' > > ; 'Linux Kernel Mailing List' > kernel@vger.kernel.org> > > Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed > > table loads > > > > It looks to me that the package objects are being initialized properly > > already, unless I'm missing something. Please check the examples below > > and in the attached files. > > > > Attached is a small test case that dynamically loads an SSDT which > > contains a package object which in turn contains references to other > > objects. > > > > > > Main DSDT: > > Method (LD1) > > { > > Load (BUF1, HNDL) // SSDT is in BUF1 > > Store (HNDL, Debug) > > Return > > } > > > > Loaded table: > > External (DEV1, DeviceObj) > > Name (PKG1, Package() { > > 1,2, DEV2, DEV1, 4}) > > Device (DEV2) {} > > > > > > AcpiExec Output: > > - ev ld1 > > Evaluating \LD1 > > ACPI: Dynamic OEM Table Load: > > ACPI: SSDT 0x00000000006DEEB8 000051 (v02 Intel Load 00000001 > INTL > > 20190509) > > ACPI Exec: Table Event INSTALL, [SSDT] 006DEEB8 > > Table [SSDT: Load ] (id 06) - 5 Objects with 1 Devices, 0 > > Regions, 1 Methods > > ACPI Exec: Table Event LOAD, [SSDT] 006DEEB8 ACPI Debug: Reference > > [DdbHandle] Table Index 0x3 > > 0x7 Outstanding allocations after evaluation of \LD1 Evaluation of > > \LD1 returned object 006D2FE8, external buffer length 18 > > [Integer] = 0000000000000000 > > > > - ev pkg1 > > Evaluating \PKG1 > > Evaluation of \PKG1 returned object 006D2FE8, external buffer length > 90 > > [Package] Contains 5 Elements: > > [Integer] = 0000000000000001 > > [Integer] = 0000000000000002 > > [Object Reference] = 006DDF88 Name DEV2 Device > > [Object Reference] = 006DD608 Name DEV1 Device > > [Integer] = 0000000000000004