From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933404AbcHaJim (ORCPT ); Wed, 31 Aug 2016 05:38:42 -0400 Received: from foss.arm.com ([217.140.101.70]:56224 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757955AbcHaJii (ORCPT ); Wed, 31 Aug 2016 05:38:38 -0400 Subject: Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU To: Mathieu Poirier , acme@kernel.org References: <1472573965-3881-1-git-send-email-mathieu.poirier@linaro.org> <1472573965-3881-6-git-send-email-mathieu.poirier@linaro.org> Cc: acme@infradead.org, peterz@infradead.org, jolsa@kernel.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Suzuki K Poulose Message-ID: <94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com> Date: Wed, 31 Aug 2016 10:37:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472573965-3881-6-git-send-email-mathieu.poirier@linaro.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/08/16 17:19, Mathieu Poirier wrote: > Using the PMU::set_drv_config() callback to enable the CoreSight > sink that will be used for the trace session. > +int cs_etm_set_drv_config(struct perf_evsel_config_term *term) > +{ > + int ret; > + char enable_sink[ENABLE_SINK_MAX]; > + > + snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s", > + term->val.drv_cfg, "enable_sink"); > + > + ret = cs_device__print_file(enable_sink, "%d", 1); > + if (ret < 0) > + return ret; > + > + return 0; > +} Don't we have to disable the sink at the end of the session ? How is that taken care of ? Did I miss that ? Suzuki