From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86667C4360C for ; Thu, 10 Oct 2019 07:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65349218AC for ; Thu, 10 Oct 2019 07:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387481AbfJJHkC (ORCPT ); Thu, 10 Oct 2019 03:40:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3683 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387469AbfJJHkB (ORCPT ); Thu, 10 Oct 2019 03:40:01 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 051659DB5E3A0C01908C; Thu, 10 Oct 2019 15:39:58 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 15:39:51 +0800 Subject: Re: [PATCH for-next 1/5] erofs: clean up collection handling routines To: Gao Xiang , CC: LKML , Miao Xie , "Li Guifu" References: <20191008125616.183715-1-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <94a79a77-6875-d60e-2a51-48460ba3ae7f@huawei.com> Date: Thu, 10 Oct 2019 15:40:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191008125616.183715-1-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/8 20:56, Gao Xiang wrote: > - change return value to int since collection is > already returned within the collector. > - better function naming. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,