From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D8A6C00140 for ; Mon, 15 Aug 2022 07:32:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233322AbiHOHcU (ORCPT ); Mon, 15 Aug 2022 03:32:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbiHOHcS (ORCPT ); Mon, 15 Aug 2022 03:32:18 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D334618B0A for ; Mon, 15 Aug 2022 00:32:16 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id tl27so12198634ejc.1 for ; Mon, 15 Aug 2022 00:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=WJLEPHsAZp8U37aoOrddvhy4zTgTsBLms1gLLOoidx8=; b=Apiwg8lXWfx0PuHphZbC+0CSw/jecCBMO4b4h6hmcINbjWREv2rl1SeXAn7r5NEZN6 BCxZfoOq0tp+FSVLcgR3MYKwJIEi/l9BfvdCuAib3La4b5VBblthG2Lj2q3O8wMlbvBI oJANIx421UuLYpOSwIMHsynvxi9Cm2EJNUDIIG5JnvF1HjGUJ9keBoofJgEeNWmS1SDy VZxC3zCdqrMwgVM/U4J1vf8M3KFgNGdrJCVK94XY/tdLJcrBE+rkLhdn1PY8XSJ31ukI vw4pcSW7DYwX7PNmhDvQvlMUSrscDHBTibnECxoWwdk7RbsserN0v8OXSXVX2UmcEkjm Bt0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=WJLEPHsAZp8U37aoOrddvhy4zTgTsBLms1gLLOoidx8=; b=cI8sEPnZrhELl7wxiPg/L0N3xQO8IImT6yiGYzzPMgIdj1PfwU9u4dxIoK5RwXXHGF CEqWK9viIk3PyF5LiWDXqtfWkeu690UtOaXkrV9HUyhrbrc66DCbMe7dvjuPEdo8Mmdi ohIgU0tfGEJJW1K5G0xIkV5NqBLD3gAKbw0qnyMbfq9D20qypvsVKWRgVuVh0YydOlW3 GT2jJT2Xpr0iB+wZBHrGjBFL8dEtHyzYmb8w3xmfa6Mb98+sq1ZqjZf/rgGxYwrLaxBI PHbfRohJR908nx8VSy6oxdQIpM2zMNPmZFGkL3noH1Q5XHuDrJAtodbJC8sHkWPDBeFs oY7Q== X-Gm-Message-State: ACgBeo03fkpxRg9jxY34W5E3cKCcBDl9lHsGEhlmZmR3cbi2Ig43hkpd Njg9YECjhcysaqqyrpQDwpx6Nw== X-Google-Smtp-Source: AA6agR5aKYPCzgLDNmCoxSU0zm6D7mFfVrKEn7+YQ7XB5w7ebixaOlegmzsNAq3fiAoaNyIoRR2CNA== X-Received: by 2002:a17:907:1ca8:b0:730:871e:498c with SMTP id nb40-20020a1709071ca800b00730871e498cmr9570990ejc.651.1660548735151; Mon, 15 Aug 2022 00:32:15 -0700 (PDT) Received: from [192.168.0.111] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id bt2-20020a0564020a4200b0043d1eff72b3sm6206029edb.74.2022.08.15.00.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 00:32:14 -0700 (PDT) Message-ID: <94ab0304-a674-3504-c1bd-3492e2ded0b1@blackwall.org> Date: Mon, 15 Aug 2022 10:32:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next] net: rtnetlink: fix module reference count leak issue in rtnetlink_rcv_msg Content-Language: en-US From: Nikolay Aleksandrov To: Zhengchao Shao , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: idosch@nvidia.com, petrm@nvidia.com, florent.fourcot@wifirst.fr, weiyongjun1@huawei.com, yuehaibing@huawei.com References: <20220815024629.240367-1-shaozhengchao@huawei.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2022 08:44, Nikolay Aleksandrov wrote: > On 15/08/2022 05:46, Zhengchao Shao wrote: >> When bulk delete command is received in the rtnetlink_rcv_msg function, >> if bulk delete is not supported, module_put is not called to release >> the reference counting. As a result, module reference count is leaked. >> >> Fixes: a6cec0bcd342("net: rtnetlink: add bulk delete support flag") >> Signed-off-by: Zhengchao Shao >> --- >> net/core/rtnetlink.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index ac45328607f7..4b5b15c684ed 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -6070,6 +6070,7 @@ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, >> if (kind == RTNL_KIND_DEL && (nlh->nlmsg_flags & NLM_F_BULK) && >> !(flags & RTNL_FLAG_BULK_DEL_SUPPORTED)) { >> NL_SET_ERR_MSG(extack, "Bulk delete is not supported"); >> + module_put(owner); >> goto err_unlock; >> } >> > > Oops, thanks. > Acked-by: Nikolay Aleksandrov By the way I think this should be targeted at -net, I didn't notice the net-next tag earlier.