From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<lee.jones@linaro.org>, <daniel.thompson@linaro.org>,
<jingoohan1@gmail.com>
Cc: <dmurphy@ti.com>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v4 2/4] leds: Add managed API to get a LED from a device driver
Date: Wed, 31 Jul 2019 16:23:07 +0300 [thread overview]
Message-ID: <94bdabf4-0922-5016-ed96-9916ed6bda9d@ti.com> (raw)
In-Reply-To: <20190717141514.21171-3-jjhiblot@ti.com>
On 17/07/2019 17:15, Jean-Jacques Hiblot wrote:
> +struct led_classdev *__must_check devm_led_get(struct device *dev,
> + int index)
> +{
> + struct led_classdev *led;
> + struct led_classdev **dr;
> +
Should you check here if dev->of_node == NULL? Or should of_led_get()
check it.
> + led = of_led_get(dev->of_node, index);
> + if (IS_ERR(led))
> + return led;
> +
> + dr = devres_alloc(devm_led_release, sizeof(struct led_classdev *),
> + GFP_KERNEL);
> + if (!dr) {
> + led_put(led);
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + *dr = led;
> + devres_add(dev, dr);
> +
> + return led;
> +}
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-07-31 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 14:15 [PATCH v4 0/4] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-07-17 14:15 ` [PATCH v4 1/4] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-07-30 11:02 ` Pavel Machek
2019-07-17 14:15 ` [PATCH v4 2/4] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-07-31 13:23 ` Tomi Valkeinen [this message]
2019-07-17 14:15 ` [PATCH v4 3/4] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-07-18 12:30 ` Jacek Anaszewski
2019-07-17 14:15 ` [PATCH v4 4/4] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-09-09 9:53 ` Daniel Thompson
2019-07-18 13:19 ` [PATCH v4 0/4] Add a generic driver for LED-based backlight Jacek Anaszewski
2019-07-22 7:06 ` Lee Jones
2019-07-22 21:23 ` Jacek Anaszewski
2019-09-08 16:17 ` Jacek Anaszewski
2019-09-09 11:12 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94bdabf4-0922-5016-ed96-9916ed6bda9d@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).