From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbeCPAvG (ORCPT ); Thu, 15 Mar 2018 20:51:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58096 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227AbeCPAvE (ORCPT ); Thu, 15 Mar 2018 20:51:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE5D860AFB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs To: Alexander Duyck Cc: Netdev , Timur Tabi , sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeff Kirsher , intel-wired-lan , LKML References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-6-git-send-email-okaya@codeaurora.org> <39dc5bb4-02b1-bf7e-fbfc-17fc484e4fb7@codeaurora.org> From: Sinan Kaya Message-ID: <95118f6e-d406-f2b6-dc67-249dc5f648f9@codeaurora.org> Date: Thu, 15 Mar 2018 20:50:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/15/2018 8:25 PM, Alexander Duyck wrote: > On Thu, Mar 15, 2018 at 4:30 PM, Sinan Kaya wrote: >> On 3/14/2018 9:41 PM, Alexander Duyck wrote: >>>> } >>>> >>> So you missed the writel in e1000_xmit_frame. You should probably get >>> that one too while you are doing these updates. The wmb() is in >>> e1000_tx_queue(). >>> >> >> I brought wmb() outside along with the next descriptor assignment to be >> similar to the rest of the other code. >> >> if wmb() and writel() are not visible in the same function, let's not touch >> the code. > > Maybe for e1000 we should just skip the driver entirely. Odds are you > aren't going to have any e1000 parts running on ARM anyway since most > of them are legacy PCI or PCI-X parts that were made over 10 years > ago. Most of your efforts would probably be best spent on igb, igbvf, > ixgbe, ixgbevf, i40e, i40evf, and fm10k. > Sure. I'll drop it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.