From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517C3C4338F for ; Wed, 25 Aug 2021 06:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E296610E9 for ; Wed, 25 Aug 2021 06:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239061AbhHYGnS (ORCPT ); Wed, 25 Aug 2021 02:43:18 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:35243 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238416AbhHYGnQ (ORCPT ); Wed, 25 Aug 2021 02:43:16 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Gvbxy1fXhz9sVG; Wed, 25 Aug 2021 08:42:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4y7WKXTVXuup; Wed, 25 Aug 2021 08:42:30 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Gvbxy0f1Vz9sV9; Wed, 25 Aug 2021 08:42:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EC0218B76A; Wed, 25 Aug 2021 08:42:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 8_K7q7wLCYoh; Wed, 25 Aug 2021 08:42:29 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5388A8B83C; Wed, 25 Aug 2021 08:42:29 +0200 (CEST) Subject: Re: [PATCH linux-next] powerpc:security: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE To: CGEL , Michael Ellerman Cc: Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , Alexey Kardashevskiy , Li Huafei , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot References: <20210825064016.70421-1-deng.changcheng@zte.com.cn> From: Christophe Leroy Message-ID: <9521dd23-34f6-837e-a397-ee2771675967@csgroup.eu> Date: Wed, 25 Aug 2021 08:42:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210825064016.70421-1-deng.changcheng@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le 25/08/2021 à 08:40, CGEL a écrit : > From: Jing Yangyang > > Fix the following coccicheck warning: > ./arch/powerpc/kernel/security.c:807:0-23: WARNING: > fops_entry_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE > ./arch/powerpc/kernel/security.c:781:0-23:WARNING: > fops_rfi_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE > ./arch/powerpc/kernel/security.c:833:0-23:WARNING: > fops_uaccess_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE Can you give a few more details why the suggestion from coccicheck is a good suggestion ? Thanks Christophe > > Reported-by: Zeal Robot > Signed-off-by: Jing Yangyang > --- > arch/powerpc/kernel/security.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kernel/security.c b/arch/powerpc/kernel/security.c > index 1a99849..cf8ce24 100644 > --- a/arch/powerpc/kernel/security.c > +++ b/arch/powerpc/kernel/security.c > @@ -778,7 +778,7 @@ static int rfi_flush_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set, "%llu\n"); > > static int entry_flush_set(void *data, u64 val) > { > @@ -804,7 +804,7 @@ static int entry_flush_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set, "%llu\n"); > > static int uaccess_flush_set(void *data, u64 val) > { > @@ -830,7 +830,7 @@ static int uaccess_flush_get(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get, uaccess_flush_set, "%llu\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get, uaccess_flush_set, "%llu\n"); > > static __init int rfi_flush_debugfs_init(void) > { >