From: brookxu <brookxu.cn@gmail.com>
To: viro@zeniv.linux.org.uk, tj@kernel.org, lizefan.x@bytedance.com,
hannes@cmpxchg.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: [RFC PATCH 3/3] misc_cgroup: delete failed logs to avoid log flooding
Date: Thu, 22 Jul 2021 17:38:40 +0800 [thread overview]
Message-ID: <9561f990656620f8b39c83453a857c5c35e3ddd0.1626946231.git.brookxu@tencent.com> (raw)
In-Reply-To: <4775e8d187920399403b296f8bb11bd687688671.1626946231.git.brookxu@tencent.com>
In-Reply-To: <4775e8d187920399403b296f8bb11bd687688671.1626946231.git.brookxu@tencent.com>
From: Chunguang Xu <brookxu@tencent.com>
Since the upper-level logic will constantly retry when it fails, in
high-stress scenarios, a large number of failure logs may affect
performance. Therefore, we can replace it with the failcnt counter.
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
kernel/cgroup/misc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/cgroup/misc.c b/kernel/cgroup/misc.c
index 7c568b619f82..b7de0fafa48a 100644
--- a/kernel/cgroup/misc.c
+++ b/kernel/cgroup/misc.c
@@ -159,8 +159,6 @@ int misc_cg_try_charge(enum misc_res_type type, struct misc_cg *cg,
if (new_usage > READ_ONCE(res->max) ||
new_usage > READ_ONCE(misc_res_capacity[type])) {
if (!res->failed) {
- pr_info("cgroup: charge rejected by the misc controller for %s resource in ",
- misc_res_name[type]);
pr_cont_cgroup_path(i->css.cgroup);
pr_cont("\n");
res->failed = true;
--
2.30.0
prev parent reply other threads:[~2021-07-22 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 9:38 [RFC PATCH 1/3] misc_cgroup: add support for nofile limit brookxu
2021-07-22 9:38 ` [RFC PATCH 2/3] misc_cgroup: add failcnt counter brookxu
2021-07-22 9:38 ` brookxu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9561f990656620f8b39c83453a857c5c35e3ddd0.1626946231.git.brookxu@tencent.com \
--to=brookxu.cn@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).