From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C541C3F2CF for ; Fri, 28 Feb 2020 04:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8FE62469D for ; Fri, 28 Feb 2020 04:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=russell.cc header.i=@russell.cc header.b="hmuZ9Bx5"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jza5eG7E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730829AbgB1ECl (ORCPT ); Thu, 27 Feb 2020 23:02:41 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:49759 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730736AbgB1ECl (ORCPT ); Thu, 27 Feb 2020 23:02:41 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 6587480F; Thu, 27 Feb 2020 23:02:39 -0500 (EST) Received: from imap35 ([10.202.2.85]) by compute5.internal (MEProxy); Thu, 27 Feb 2020 23:02:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=russell.cc; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm1; bh=yDNr6 cIp+q6/+ecebXB5XIPiNj/FLJ3ZWp+FFBnyePQ=; b=hmuZ9Bx5DouFkImGnpHjm afcJX/vqOgpiYmp/4/McrkRHqA5EuONL655Qj+b+4j7J9hIBZF6UGjUZHIj60nzm 0FPYZtRoklOBQUH59CMzJm0vWGOAUG1iprX88rA9hLvlHT61MwDiChTnKUbeeHml /pJ3B8cX7jwygwseJyn1Yjc/6GobbY4lbfQ6AGNTG2yFRFpO4rhrQp/ql8sTacKL QRF/u0LAewxfBWuHa64sLLhnX7nVJ/0gxARS/QcINiJh7D0lQB1B3g4NKoOyJvwh Q0zfz1aqWaCAEjVvybXhnVDZU4EuHd5zJZhP3FuBzMqvQMV4523qMcqEF0b+1oUw w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yDNr6cIp+q6/+ecebXB5XIPiNj/FLJ3ZWp+FFBnye PQ=; b=jza5eG7Er+x/TQZ1O99s6GZ+cQRP5fd9XdaDO3xN7UPh0DR19ZgIiiyS3 8i1OSuKAk4SerQRk+WUSFDgGFxjnItViPKA7T86pCOTR2uCtx4iOFEnD0gnIhSwA XQOzFSM0lfoyol2q1SfiHNBSsJd9llACE6j+3+sjWszXCMZRWUpI2qwi9DxBVEAK cJmHgXXa1HGp7Cf1FKUqvEHAPaMpMtn0aBgO/OfoCxgq1J8D+PAF11bCSxe5gwiX oAFKer+RFqXTDNjmypair9hJ/AKsyNMNHRd3jGcTafGzF4k6bzf2RsNGoYbu9E/c bs12/b8/NQOepHyWbENFGpFWZsoHw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleejgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculddvtddmnecujfgurhepofgfggfkjghffffhvffutgfgsehtqhertder reejnecuhfhrohhmpedftfhushhsvghllhcuvehurhhrvgihfdcuoehruhhstghurhesrh hushhsvghllhdrtggtqeenucffohhmrghinhepohiilhgrsghsrdhorhhgpdhophgvnhhp ohifvghrrdighiiinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprhhushgtuhhrsehruhhsshgvlhhlrdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0ACB414C014D; Thu, 27 Feb 2020 23:02:37 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-967-g014f925-fmstable-20200226v1 Mime-Version: 1.0 Message-Id: <95816cae-565b-40a8-a3bf-4733672c6e91@www.fastmail.com> In-Reply-To: References: <4e528bf2-2b53-ae93-cdcc-0c80953f40f2@c-s.fr> <87pndz1xsf.fsf@mpe.ellerman.id.au> Date: Fri, 28 Feb 2020 15:02:14 +1100 From: "Russell Currey" To: "Andrew Donnellan" , "Michael Ellerman" , "Christophe Leroy" , "Benjamin Herrenschmidt" , "Paul Mackerras" , mikey@neuling.org Cc: linuxppc-dev@lists.ozlabs.org, "Linux Kernel Mailing List" Subject: =?UTF-8?Q?Re:_[PATCH_v4_13/13]_powerpc/ptrace:_move_ptrace=5Ftriggered()?= =?UTF-8?Q?_into_hw=5Fbreakpoint.c?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This was my fault, I should really test changes like these before they g= o live. Apologies for the confusion caused --=20 Russell Currey ruscur@russell.cc On Fri, Feb 28, 2020, at 2:59 PM, Andrew Donnellan wrote: > On 28/2/20 9:16 am, Michael Ellerman wrote: > > Christophe Leroy writes: > >> Russel, > >> > >> Le 27/02/2020 =C3=A0 12:49, Christophe Leroy a =C3=A9crit=C2=A0: > >>> ptrace_triggered() is declared in asm/hw_breakpoint.h and > >>> only needed when CONFIG_HW_BREAKPOINT is set, so move it > >>> into hw_breakpoint.c > >> > >> My series v4 is definitely buggy (I included ptrace_decl.h instead > >> instead of ptrace-decl.h), how can Snowpatch say build succeeded > >> (https://patchwork.ozlabs.org/patch/1245807/) ? > >=20 > > Which links to: > > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15= 895//artifact/linux/report.txt > >=20 > > The actual build log of which is: > > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15= 895/artifact/linux/build_new.log > >=20 > > Which contains: > > scripts/Makefile.build:267: recipe for target 'arch/powerpc/kerne= l/ptrace/ptrace-altivec.o' failed > > make[3]: *** [arch/powerpc/kernel/ptrace/ptrace-altivec.o] Error = 1 > > make[3]: *** Waiting for unfinished jobs.... > > scripts/Makefile.build:505: recipe for target 'arch/powerpc/kerne= l/ptrace' failed > > make[2]: *** [arch/powerpc/kernel/ptrace] Error 2 > > make[2]: *** Waiting for unfinished jobs.... > > scripts/Makefile.build:505: recipe for target 'arch/powerpc/kerne= l' failed > > make[1]: *** [arch/powerpc/kernel] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > > Makefile:1681: recipe for target 'arch/powerpc' failed > > make: *** [arch/powerpc] Error 2 > > make: *** Waiting for unfinished jobs.... > >=20 > > Same for ppc64le: > > https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15= 896/artifact/linux/build_new.log > >=20 > >=20 > > So it seems like snowpatch always reports the build as succeeded eve= n > > when it fails. >=20 > Turns out there was an issue in a recent change in our build script=20= > which caused build failures to return the wrong exit code and put the=20= > wrong text in the reports, because of some confusion with bash=20 > subshells. I've fixed it (I think). >=20 > --=20 > Andrew Donnellan OzLabs, ADL Canberra > ajd@linux.ibm.com IBM Australia Limited >=20 >