From: Joey Pabalinas <joeypabalinas@gmail.com> To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Daniel Martin <consume.noise@gmail.com> Subject: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks Date: Sat, 30 Jun 2018 14:19:50 -1000 [thread overview] Message-ID: <958e450a066289c94ba03429166c972c54be6fb3.1530402641.git.joeypabalinas@gmail.com> (raw) In-Reply-To: <cover.1530402641.git.joeypabalinas@gmail.com> The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 45968f7970f87775fa..a793076139d7d0db9b 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -242,11 +242,12 @@ static struct mt_class mt_classes[] = { .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_IGNORE_DUPLICATES | MT_QUIRK_HOVERING | MT_QUIRK_CONTACT_CNT_ACCURATE | MT_QUIRK_STICKY_FINGERS | - MT_QUIRK_WIN8_PTP_BUTTONS }, + MT_QUIRK_WIN8_PTP_BUTTONS | + MT_QUIRK_NOT_SEEN_MEANS_UP }, { .name = MT_CLS_EXPORT_ALL_INPUTS, .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_CONTACT_CNT_ACCURATE, .export_all_inputs = true }, { .name = MT_CLS_WIN_8_DUAL, -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Joey Pabalinas <joeypabalinas@gmail.com> To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Daniel Martin <consume.noise@gmail.com> Subject: [PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks Date: Thu, 9 Aug 2018 13:39:16 -1000 [thread overview] Message-ID: <958e450a066289c94ba03429166c972c54be6fb3.1530402641.git.joeypabalinas@gmail.com> (raw) Message-ID: <20180809233916.BduCYrghDsSudKsiT8nKde3cWEt6EkNmLIPsMk_0FXM@z> (raw) In-Reply-To: <cover.1530402641.git.joeypabalinas@gmail.com> The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 45968f7970f87775fa..a793076139d7d0db9b 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -242,11 +242,12 @@ static struct mt_class mt_classes[] = { .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_IGNORE_DUPLICATES | MT_QUIRK_HOVERING | MT_QUIRK_CONTACT_CNT_ACCURATE | MT_QUIRK_STICKY_FINGERS | - MT_QUIRK_WIN8_PTP_BUTTONS }, + MT_QUIRK_WIN8_PTP_BUTTONS | + MT_QUIRK_NOT_SEEN_MEANS_UP }, { .name = MT_CLS_EXPORT_ALL_INPUTS, .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_CONTACT_CNT_ACCURATE, .export_all_inputs = true }, { .name = MT_CLS_WIN_8_DUAL, -- 2.18.0
next prev parent reply other threads:[~2018-07-01 0:20 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-01 0:19 [PATCH 0/4] reduce Surface Pro 3 multitouch jitter Joey Pabalinas 2018-07-01 0:19 ` Joey Pabalinas [this message] 2018-07-03 7:53 ` [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks Benjamin Tissoires 2018-08-09 23:57 ` Joey Pabalinas 2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas 2018-08-10 3:54 ` Joey Pabalinas 2018-07-01 0:19 ` [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol Joey Pabalinas 2018-07-03 8:16 ` Benjamin Tissoires 2018-08-10 3:50 ` Joey Pabalinas 2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas 2018-07-01 0:19 ` [PATCH 3/4] HID: multitouch: drop reports containing invalid values Joey Pabalinas 2018-07-03 8:13 ` Benjamin Tissoires 2018-08-10 3:27 ` Joey Pabalinas 2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas 2018-07-01 0:19 ` [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases Joey Pabalinas 2018-07-03 8:17 ` Benjamin Tissoires 2018-08-10 0:03 ` Joey Pabalinas 2018-08-09 23:39 ` [PATCH RESEND " Joey Pabalinas 2018-08-09 23:39 ` [PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter Joey Pabalinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=958e450a066289c94ba03429166c972c54be6fb3.1530402641.git.joeypabalinas@gmail.com \ --to=joeypabalinas@gmail.com \ --cc=benjamin.tissoires@redhat.com \ --cc=consume.noise@gmail.com \ --cc=jikos@kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).