archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <>
To: Stephen Boyd <>
Cc: Andy Gross <>,
	Bjorn Andersson <>,
	Greg Kroah-Hartman <>,
	Michael Turquette <>,
	Pavel Machek <>,
	"Rafael J. Wysocki" <>,
	Taniya Das <>,
	Linux PM <>,
	open list <>,
	"open list:COMMON CLK FRAMEWORK" <>,
Subject: Re: [PATCH v3 0/3] PM: add two devres helpers and use them in qcom cc
Date: Mon, 16 Aug 2021 20:08:39 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 06/08/2021 10:08, Dmitry Baryshkov wrote:
> On Fri, 6 Aug 2021 at 02:53, Stephen Boyd <> wrote:
>> Quoting Dmitry Baryshkov (2021-07-31 12:50:31)
>>> Most of the drivers using using pm_runtime_enable() or pm_clk_create()
>>> follow the same pattern: call the function in the probe() path and call
>>> correspondingly pm_runtime_disable() or pm_clk_destroy() from the
>>> probe()'s error path and from the remove() function. This common code
>>> pattern has several drawbacks. I.e. driver authors have to ensure that
>>> the disable/destroy call in the error path really corresponds to the
>>> proper error clause. Or that the disable/destroy call is not missed in
>>> the remove() callback.
>>> Add two devres helpers replacing these code patterns with relevant devm
>>> function call, removing the need to call corresponding disable/destroy
>>> functions. As an example modify Qualcomm clock controller code to use
>>> new helpers. In this case we are able to drop error path and remove
>>> functions completely, simplifying the drivers in question.
>> There are lots of folks on the To: line so I'm not sure who is supposed
>> to apply this. Please indicate which maintainer tree you're planning to
>> land a series through if it touches different areas of the tree.
> I'd prefer for them to go through the clock tree.

Stephen, since Rafael has acked the patched, could you please take a 
look and hopefully merge them?

With best wishes

      reply	other threads:[~2021-08-16 17:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 19:50 [PATCH v3 0/3] PM: add two devres helpers and use them in qcom cc Dmitry Baryshkov
2021-07-31 19:50 ` [PATCH v3 1/3] PM: runtime: add devm_pm_runtime_enable helper Dmitry Baryshkov
2021-08-04 18:06   ` Rafael J. Wysocki
2021-08-04 21:02     ` Dmitry Baryshkov
2021-08-06 13:27       ` Rafael J. Wysocki
2021-07-31 19:50 ` [PATCH v3 2/3] PM: runtime: add devm_pm_clk_create helper Dmitry Baryshkov
2021-08-31 12:15   ` Geert Uytterhoeven
2021-07-31 19:50 ` [PATCH v3 3/3] clk: qcom: use devm_pm_runtime_enable and devm_pm_clk_create Dmitry Baryshkov
2021-08-04 18:12   ` Rafael J. Wysocki
     [not found] ` <>
2021-08-06  7:08   ` [PATCH v3 0/3] PM: add two devres helpers and use them in qcom cc Dmitry Baryshkov
2021-08-16 17:08     ` Dmitry Baryshkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).