* [PATCH] drm/gma500: select framebuffer dependency
@ 2022-04-09 2:59 James Hilliard
2022-04-09 3:11 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2022-04-09 2:59 UTC (permalink / raw)
To: dri-devel
Cc: James Hilliard, Patrik Jakobsson, David Airlie, Daniel Vetter,
linux-kernel
This appears to be needed for video output to function correctly.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
drivers/gpu/drm/gma500/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
index 0cff20265f97..ff8c7b6e87f5 100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -7,6 +7,8 @@ config DRM_GMA500
select ACPI_VIDEO if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
select INPUT if ACPI
+ select FB
+ select FB_EFI if EFI
help
Say yes for an experimental 2D KMS framebuffer driver for the
Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/gma500: select framebuffer dependency
2022-04-09 2:59 [PATCH] drm/gma500: select framebuffer dependency James Hilliard
@ 2022-04-09 3:11 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-04-09 3:11 UTC (permalink / raw)
To: James Hilliard, dri-devel
Cc: Patrik Jakobsson, David Airlie, Daniel Vetter, linux-kernel
Hi,
On 4/8/22 19:59, James Hilliard wrote:
> This appears to be needed for video output to function correctly.
More proof/justification?
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> drivers/gpu/drm/gma500/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 0cff20265f97..ff8c7b6e87f5 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -7,6 +7,8 @@ config DRM_GMA500
> select ACPI_VIDEO if ACPI
> select BACKLIGHT_CLASS_DEVICE if ACPI
> select INPUT if ACPI
> + select FB
Preferably
depends on FB
There are a few instances of an arch (or board) selecting FB,
which makes some sense, but other drivers shouldn't be doing
that IMO.
> + select FB_EFI if EFI
> help
> Say yes for an experimental 2D KMS framebuffer driver for the
> Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-09 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 2:59 [PATCH] drm/gma500: select framebuffer dependency James Hilliard
2022-04-09 3:11 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).