From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2 1/2] drivers: thermal: tsens: fix wrong check for tzd in irq handlers
Date: Fri, 17 Sep 2021 11:08:30 +0200 [thread overview]
Message-ID: <95c7a633-144c-917b-376f-636b904f8b73@linaro.org> (raw)
In-Reply-To: <20210907212543.20220-1-ansuelsmth@gmail.com>
Applied, thanks
On 07/09/2021 23:25, Ansuel Smith wrote:
> Some device can have some thermal sensor disabled from the factory. The
> current 2 irq handler functions check all the sensor by default and the
> check if the sensor was actually registered is wrong. The tzd is
> actually never set if the registration fail hence the IS_ERR check is
> wrong.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/thermal/qcom/tsens.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 4c7ebd1d3f9c..b1162e566a70 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -417,7 +417,7 @@ static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> const struct tsens_sensor *s = &priv->sensor[i];
> u32 hw_id = s->hw_id;
>
> - if (IS_ERR(s->tzd))
> + if (!s->tzd)
> continue;
> if (!tsens_threshold_violated(priv, hw_id, &d))
> continue;
> @@ -467,7 +467,7 @@ static irqreturn_t tsens_irq_thread(int irq, void *data)
> const struct tsens_sensor *s = &priv->sensor[i];
> u32 hw_id = s->hw_id;
>
> - if (IS_ERR(s->tzd))
> + if (!s->tzd)
> continue;
> if (!tsens_threshold_violated(priv, hw_id, &d))
> continue;
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2021-09-17 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 21:25 [PATCH v2 1/2] drivers: thermal: tsens: fix wrong check for tzd in irq handlers Ansuel Smith
2021-09-07 21:25 ` [PATCH v2 2/2] drivers: thermal: tsens: add timeout to get_tem_tsens_valid Ansuel Smith
2021-09-07 21:57 ` Matthias Kaehlcke
2021-09-17 9:08 ` Daniel Lezcano
2021-09-17 11:06 ` Ansuel Smith
2021-09-17 9:08 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95c7a633-144c-917b-376f-636b904f8b73@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).