From: Dusty Mabe <dusty@dustymabe.com>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org
Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk
Date: Mon, 12 Sep 2022 22:36:08 -0400 [thread overview]
Message-ID: <95cbd47d-46ed-850e-7d4f-851b35d03069@dustymabe.com> (raw)
In-Reply-To: <Yx/jLTknQm9VeHi4@T590>
On 9/12/22 21:55, Ming Lei wrote:
> On Mon, Sep 12, 2022 at 09:16:18AM +0200, Christoph Hellwig wrote:
>> On Fri, Sep 09, 2022 at 04:24:40PM +0800, Ming Lei wrote:
>>> On Wed, Sep 07, 2022 at 09:33:24AM +0200, Christoph Hellwig wrote:
>>>> On Thu, Sep 01, 2022 at 03:06:08PM +0800, Ming Lei wrote:
>>>>> It is a bit hard to associate the above commit with reported issue.
>>>>
>>>> So the messages clearly are about something trying to open a device
>>>> that went away at the block layer, but somehow does not get removed
>>>> in time by udev (which seems to be a userspace bug in CoreOS). But
>>>> even with that we really should not hang.
>>>
>>> Xiao Ni provides one script[1] which can reproduce the issue more or less.
>>
>> I've run the reproduced 10000 times on current mainline, and while
>> it prints one of the autoloading messages per run, I've not actually
>> seen any kind of hang.
>
> I can't reproduce the hang too.
I obviously can reproduce the issue with the test in our Fedora CoreOS
test suite. It's part of a framework (i.e. it's not simple some script
you can run) but it is very reproducible so one can add some instrumentation
to the kernel and feed it through a build/test cycle to see different
results or logs.
I'm willing to share this with other people (maybe a screen share or
some written down instructions) if anyone would be interested.
>
> What I meant is that new raid disk can be added by mdadm after stopping
> the imsm container and raid disk with the autoloading messages printed,
> I understand this behavior isn't correct, but I am not familiar with
> raid enough.
>
> It might be related with the delay deleting gendisk from wq & md kobj
> release handler.
>
> During reboot, if mdadm does this stupid thing without stopping, the hang
> could be caused.
>
> I think the root cause is that why mdadm tries to open/add new raid bdev
> crazily during reboot.
>
Dusty
next prev parent reply other threads:[~2022-09-13 2:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 16:15 regression caused by block: freeze the queue earlier in del_gendisk Dusty Mabe
2022-08-28 10:24 ` Thorsten Leemhuis
2022-08-31 12:36 ` Thorsten Leemhuis
2022-09-01 7:06 ` Ming Lei
2022-09-03 13:47 ` Dusty Mabe
2022-09-07 7:33 ` Christoph Hellwig
2022-09-07 8:38 ` Ming Lei
2022-09-07 14:40 ` Chaitanya Kulkarni
2022-09-07 14:58 ` Ming Lei
2022-09-07 15:53 ` Chaitanya Kulkarni
2022-09-09 8:24 ` Ming Lei
2022-09-12 7:16 ` Christoph Hellwig
2022-09-13 1:55 ` Ming Lei
2022-09-13 2:36 ` Dusty Mabe [this message]
2022-09-20 9:11 ` Thorsten Leemhuis
2022-09-20 14:05 ` Jens Axboe
2022-09-20 14:12 ` Christoph Hellwig
2022-09-20 14:14 ` Jens Axboe
2022-09-21 9:25 ` Thorsten Leemhuis
2022-09-21 14:34 ` Jens Axboe
2022-09-21 14:47 ` Greg KH
2022-09-21 14:56 ` Jens Axboe
2022-09-26 7:09 ` Greg KH
2022-09-07 7:22 ` Christoph Hellwig
2022-09-07 14:56 ` Dusty Mabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95cbd47d-46ed-850e-7d4f-851b35d03069@dustymabe.com \
--to=dusty@dustymabe.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).