linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-rtc@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 0/4] selftests: rework RTC tests
Date: Tue, 24 Apr 2018 13:33:01 -0600	[thread overview]
Message-ID: <95d19039-69ee-cda5-3cfe-918283cf9913@kernel.org> (raw)
In-Reply-To: <20180419125030.5076-1-alexandre.belloni@bootlin.com>

On 04/19/2018 06:50 AM, Alexandre Belloni wrote:
> Hi,
> 
> This series separates tests using the RTC devices between the one
> testing driver agnostic kernel facilities (timers) and the others that
> are testing device drivers and hardware.
> 
> Then, rtctest is reworked to use the test harness and be much more
> robust. Skipping tests is now easier and tests will not block
> indefinitively.
> 
> I'm planning to send more improvements later this cycle.
> 
> Alexandre Belloni (4):
>   selftests: timers: move PIE tests out of rtctest
>   selftests: timers: rtcpie: restore previous PIE rate
>   selftests: move RTC tests to rtc subfolder
>   selftests: rtc: rework rtctest
> 
>  MAINTAINERS                                   |   2 +-
>  tools/testing/selftests/Makefile              |   1 +
>  tools/testing/selftests/rtc/.gitignore        |   2 +
>  tools/testing/selftests/rtc/Makefile          |   9 +
>  tools/testing/selftests/rtc/rtctest.c         | 238 +++++++++++
>  .../rtctest_setdate.c => rtc/setdate.c}       |   0
>  tools/testing/selftests/timers/.gitignore     |   3 +-
>  tools/testing/selftests/timers/Makefile       |   4 +-
>  tools/testing/selftests/timers/rtcpie.c       | 134 ++++++
>  tools/testing/selftests/timers/rtctest.c      | 403 ------------------
>  10 files changed, 388 insertions(+), 408 deletions(-)
>  create mode 100644 tools/testing/selftests/rtc/.gitignore
>  create mode 100644 tools/testing/selftests/rtc/Makefile
>  create mode 100644 tools/testing/selftests/rtc/rtctest.c
>  rename tools/testing/selftests/{timers/rtctest_setdate.c => rtc/setdate.c} (100%)
>  create mode 100644 tools/testing/selftests/timers/rtcpie.c
>  delete mode 100644 tools/testing/selftests/timers/rtctest.c
> 

Looks good to me. Thanks for doing this. I will queue this for 4.18-rc1

thanks,
-- Shuah

  parent reply	other threads:[~2018-04-24 19:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 12:50 [PATCH 0/4] selftests: rework RTC tests Alexandre Belloni
2018-04-19 12:50 ` [PATCH 1/4] selftests: timers: move PIE tests out of rtctest Alexandre Belloni
2018-11-29 19:57   ` Rafael David Tinoco
2018-12-01  9:55     ` Alexandre Belloni
2018-04-19 12:50 ` [PATCH 2/4] selftests: timers: rtcpie: restore previous PIE rate Alexandre Belloni
2018-04-19 12:50 ` [PATCH 3/4] selftests: move RTC tests to rtc subfolder Alexandre Belloni
2018-04-19 12:50 ` [PATCH 4/4] selftests: rtc: rework rtctest Alexandre Belloni
2018-04-24 19:33 ` Shuah Khan [this message]
2018-05-10 17:34   ` [PATCH 0/4] selftests: rework RTC tests Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95d19039-69ee-cda5-3cfe-918283cf9913@kernel.org \
    --to=shuah@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).