linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: tianxianting <xianting.tian@linux.alibaba.com>,
	Xianting Tian <xianting_tian@126.com>,
	mst@redhat.com, jasowang@redhat.com
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
Date: Fri, 16 Jul 2021 14:53:42 +0200	[thread overview]
Message-ID: <95d7f688-79fc-05dc-87ca-da46e0179f0e@redhat.com> (raw)
In-Reply-To: <bbe52a89-c7ea-c155-6226-0397f223cd80@linux.alibaba.com>

On 16.07.21 14:46, tianxianting wrote:
> Do you interest in this patch? just little improvment:)

I am, especially when I'm cc'ed and aware of it ;)

Reviewed-by: David Hildenbrand <david@redhat.com>

One nit below

> 
> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>
>> Use the helper virtio_find_vqs().
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>>    drivers/virtio/virtio_balloon.c | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
>> index 510e931..18e0bf3 100644
>> --- a/drivers/virtio/virtio_balloon.c
>> +++ b/drivers/virtio/virtio_balloon.c
>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>>    		callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>>    	}
>>    
>> -	err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
>> -					 vqs, callbacks, names, NULL, NULL);
>> +	err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>> +				callbacks, names, NULL);
				^
we tend to indent this such that it is aligned with the line above (see 
the old code), unless the code becomes unreadable


-- 
Thanks,

David / dhildenb


  reply	other threads:[~2021-07-16 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 15:38 [PATCH] virtio-balloon: Use virtio_find_vqs() helper Xianting Tian
2021-07-16 12:46 ` tianxianting
2021-07-16 12:53   ` David Hildenbrand [this message]
2021-07-16 13:10     ` David Hildenbrand
2021-07-16 14:18       ` tianxianting
2021-07-19  3:46   ` Jason Wang
2021-07-19  4:22     ` tianxianting
2021-07-20  2:41       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95d7f688-79fc-05dc-87ca-da46e0179f0e@redhat.com \
    --to=david@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xianting.tian@linux.alibaba.com \
    --cc=xianting_tian@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).