From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE129C4361B for ; Tue, 15 Dec 2020 07:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C8042078B for ; Tue, 15 Dec 2020 07:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbgLOHKv (ORCPT ); Tue, 15 Dec 2020 02:10:51 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51360 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgLOHKv (ORCPT ); Tue, 15 Dec 2020 02:10:51 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BF799Zu047587; Tue, 15 Dec 2020 01:09:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1608016149; bh=fNRq+gOfrdMwuLy2nUKc+a0umMFiha80ZqqipUQ7GjI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=nIfK4UmtJX+4YT+uFZjIfdGIROvpQMEUPq69q+VnzUUNKEv6l1ZqiFK+mYyHP+B71 oKzNXVzg6crDJV+KpHJwRsR+chryLG6CDGMfKQwzO8xwQXpyc3Wck+2s483ZUcP+Ap jhRRefqu1yf5pLoXhzIovUwX6KB1ZJNJhT5UaUQc= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BF799k0063765 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Dec 2020 01:09:09 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 15 Dec 2020 01:09:08 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 15 Dec 2020 01:09:08 -0600 Received: from [10.250.235.36] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BF794NZ109620; Tue, 15 Dec 2020 01:09:05 -0600 Subject: Re: [PATCH v4 1/2] dt-bindings: pci: Retrain Link to work around Gen2 training defect. To: Rob Herring CC: Athani Nadeem Ladkhan , Tom Joseph , Lorenzo Pieralisi , Bjorn Helgaas , PCI , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Milind Parab , Swapnil Kashinath Jakhade , Parshuram Raju Thombare References: <20201211144236.3825-1-nadeem@cadence.com> <20201211144236.3825-2-nadeem@cadence.com> <912c1efa-6c25-9e5d-5094-6c9dd8e3755d@ti.com> From: Kishon Vijay Abraham I Message-ID: <95f35432-3360-c855-9f87-cec4e3f57282@ti.com> Date: Tue, 15 Dec 2020 12:38:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/12/20 8:35 pm, Rob Herring wrote: > On Sun, Dec 13, 2020 at 10:21 PM Kishon Vijay Abraham I wrote: >> >> Hi Nadeem, >> >> On 12/12/20 12:37 pm, Athani Nadeem Ladkhan wrote: >>> Hi Rob / Kishon, >>> >>>> -----Original Message----- >>>> From: Rob Herring >>>> Sent: Friday, December 11, 2020 10:32 PM >>>> To: Athani Nadeem Ladkhan >>>> Cc: Tom Joseph ; Lorenzo Pieralisi >>>> ; Bjorn Helgaas ; PCI >>>> ; linux-kernel@vger.kernel.org; Kishon Vijay >>>> Abraham I ; devicetree@vger.kernel.org; Milind Parab >>>> ; Swapnil Kashinath Jakhade >>>> ; Parshuram Raju Thombare >>>> >>>> Subject: Re: [PATCH v4 1/2] dt-bindings: pci: Retrain Link to work around >>>> Gen2 training defect. >>>> >>>> EXTERNAL MAIL >>>> >>>> >>>> On Fri, Dec 11, 2020 at 9:03 AM Nadeem Athani >>>> wrote: >>>>> >>>>> Cadence controller will not initiate autonomous speed change if >>>>> strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed >>>> change. >>>>> Adding a quirk flag based on a new compatible string. >>>>> >>>>> Signed-off-by: Nadeem Athani >>>>> --- >>>>> Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml | 4 >>>>> +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml >>>>> b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml >>>>> index 293b8ec318bc..204d78f9efe3 100644 >>>>> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml >>>>> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml >>>>> @@ -15,7 +15,9 @@ allOf: >>>>> >>>>> properties: >>>>> compatible: >>>>> - const: cdns,cdns-pcie-host >>>>> + enum: >>>>> + - cdns,cdns-pcie-host >>>>> + - cdns,cdns-pcie-host-quirk-retrain >>>> >>>> So, we'll just keep adding quirk strings on to the compatible? I don't think so. >>>> Compatible strings should map to a specific implementation/platform and >>>> quirks can then be implied from them. This is the only way we can implement >>>> quirks in the OS without firmware >>>> (DT) changes. >>> Ok, I will change the compatible string to " ti,j721e-pcie-host" in place of " cdns,cdns-pcie-host-quirk-retrain" . >>> @Kishon Vijay Abraham I: Is this fine? Or will you suggest an appropriate name? >> >> IMHO it should be something like "cdns,cdns-pcie-host-vX", since the >> quirk itself is not specific to TI platform rather Cadence IP version. > > That's fine if Cadence has a need for it, but for TI platforms use the > TI compatible string. ECOs on version X IP without changing X is not > uncommon. Okay. I re-worked the patch to be applicable only to TI's J721E SoC http://lore.kernel.org/r/20201215070009.27937-1-kishon@ti.com Thank You, Kishon