From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07DBC433FE for ; Thu, 19 May 2022 09:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234712AbiESJzf (ORCPT ); Thu, 19 May 2022 05:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbiESJzc (ORCPT ); Thu, 19 May 2022 05:55:32 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C5957DE20 for ; Thu, 19 May 2022 02:55:31 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id d15so8189559lfk.5 for ; Thu, 19 May 2022 02:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8iF3UaHJz/R8aM+s3URNlw0NT0xF2iDl2EcZdkvvV7A=; b=J5wsDWlXmp/UzvINznrAJAUAdPcIzVa7wDjgy9N+NieAwbj0HWAlRVWRMXoUPG9zoM Xb1FmAVgosK0gmu+DYtRFaGr0quMZU1bXpckGQQm9DdtpEvTyxkBqUPDlIwExhkjXOcN 1XvkI5lrs4prNpHZRlnq8lgYTNR/qs66Jd2JaNeizc+/z+PhQ9JClNIT5rsQuWGcKOZE hGyYhpj1EwWR9xKp0Z4OuG0A7Oe2pJtCrzHe8zvUDcD9IpW2pVOkeOl70Lx+rGNk9/Ce SUE7rnhhXwIuYQf+qmdLwEnrDZrtk4xEPm4EbfEMPUyVdvsnB6cerUlhz6Y3lZqs+5jh ujtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8iF3UaHJz/R8aM+s3URNlw0NT0xF2iDl2EcZdkvvV7A=; b=YD/gPMr97aUE91HzRgIlEOoI6icKYgtgT0cjmH3/Opbknm99b99F4MNto3tOQJkguv hUpTgd3xpeuwwThFmUFhAUWRryBlOxAZOG+urv7BN8rbB+izaAlBJkKag5qXIT6ZZ1Z9 9GqMPEb2kVbkS3jjxtesKGHO+hmBXidtG26NqJ5Lng0qicCSPPAicRlZ1ob0PQtStNEp ikNy/pBVxFlEADufqyi47eBLll+twlioEF1cErgePa7UW2Gzl5AsN+xpW4Vl15iGJXQ6 QgiPIRVIzTRad29vLEU6Q0c9B5Tr7bTSub4BDTlCTRGeRhY7KZoouV8Do/m8zGHi/WQN 6vZA== X-Gm-Message-State: AOAM53016/ppLMVcxlIXRtlvEakqQKAZR6wCO6/y3rX03SNZ7OW4a3Ac GiZrHceqpsXIjcNYLlRRP2lIsA== X-Google-Smtp-Source: ABdhPJwakRuYm2xbt6qvpG2AHFU6Zu0vMbIHjSqxKArsiDl1n3n0t47ceOw05iSjNDeb+xPurQc/xQ== X-Received: by 2002:a05:6512:401d:b0:473:c7e2:f3ca with SMTP id br29-20020a056512401d00b00473c7e2f3camr2800141lfb.153.1652954130006; Thu, 19 May 2022 02:55:30 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u1-20020ac24c21000000b0047255d2118csm232098lfq.187.2022.05.19.02.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 02:55:29 -0700 (PDT) Message-ID: <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> Date: Thu, 19 May 2022 11:55:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Content-Language: en-US To: Corentin Labbe , andrew@lunn.ch, broonie@kernel.org, calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220518200939.689308-5-clabbe@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/05/2022 22:09, Corentin Labbe wrote: > Add entries for the new optional regulators. Please explain why do you need it. > > Signed-off-by: Corentin Labbe > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index ed1415a4381f..bd59e5cc0a55 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -153,6 +153,15 @@ properties: > used. The absence of this property indicates the muxers > should be configured so that the external PHY is used. > > + regulators: > + description: > + List of phandle to regulators needed for the PHY I don't understand that... is your PHY defining the regulators or using supplies? If it needs a regulator (as a supply), you need to document supplies, using existing bindings. > + > + regulator-names: > + description: > + List of regulator name strings sorted in the same order as the > + regulators property. > + > resets: > maxItems: 1 > Best regards, Krzysztof