linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Engraf <david.engraf@sysgo.com>
To: zhanglin <zhang.lin16@zte.com.cn>, akpm@linux-foundation.org
Cc: rppt@linux.ibm.com, steven.price@arm.com, geert@linux-m68k.org,
	linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
	wang.yi59@zte.com.cn, jiang.xuexin@zte.com.cn
Subject: Re: [PATCH] initramfs: forcing panic when kstrdup failed
Date: Tue, 10 Dec 2019 08:07:41 +0100	[thread overview]
Message-ID: <96005ea6-2192-220b-40c1-be369946fdfe@sysgo.com> (raw)
In-Reply-To: <1575946121-30548-1-git-send-email-zhang.lin16@zte.com.cn>

On 10.12.19 at 03:48, zhanglin wrote:
> preventing further undefined behaviour when kstrdup failed.
> 
> Signed-off-by: zhanglin <zhang.lin16@zte.com.cn>
> ---
>   init/initramfs.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/init/initramfs.c b/init/initramfs.c
> index fca899622937..39a4fba48cc7 100644
> --- a/init/initramfs.c
> +++ b/init/initramfs.c
> @@ -125,6 +125,8 @@ static void __init dir_add(const char *name, time64_t mtime)
>   		panic("can't allocate dir_entry buffer");
>   	INIT_LIST_HEAD(&de->list);
>   	de->name = kstrdup(name, GFP_KERNEL);
> +	if (!de->name)
> +		panic("can't allocate dir_entry.name buffer");
>   	de->mtime = mtime;
>   	list_add(&de->list, &dir_list);
>   }
> @@ -340,6 +342,8 @@ static int __init do_name(void)
>   				if (body_len)
>   					ksys_ftruncate(wfd, body_len);
>   				vcollected = kstrdup(collected, GFP_KERNEL);
> +				if (!vcollected)
> +					panic("can not allocate vcollected buffer.");

I would change the message to have the same naming as the other out of 
memory messages:

panic("can't allocate vcollected buffer");

Best regards
- David

>   				state = CopyFile;
>   			}
>   		}
> 


  reply	other threads:[~2019-12-10  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10  2:48 [PATCH] initramfs: forcing panic when kstrdup failed zhanglin
2019-12-10  7:07 ` David Engraf [this message]
2019-12-10  8:15 ` Geert Uytterhoeven
2019-12-11  0:52   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96005ea6-2192-220b-40c1-be369946fdfe@sysgo.com \
    --to=david.engraf@sysgo.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=jiang.xuexin@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@linux.ibm.com \
    --cc=steven.price@arm.com \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    --cc=zhang.lin16@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).