From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbcLFHgY (ORCPT ); Tue, 6 Dec 2016 02:36:24 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36670 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcLFHgW (ORCPT ); Tue, 6 Dec 2016 02:36:22 -0500 Subject: Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 To: Maxime Ripard References: <20161205020032.26586-1-woogyom.kim@gmail.com> <20161205080932.xaqyl2httgxgso67@lukather> Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Milo Kim Message-ID: <9607940c-1ca9-bb49-291e-ddc7e77546be@gmail.com> Date: Tue, 6 Dec 2016 16:23:57 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161205080932.xaqyl2httgxgso67@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2016 05:09 PM, Maxime Ripard wrote: > On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote: >> The board has DDR3 512MB. This patch helps scanning the memory and >> adding memblock through the DT. >> >> Signed-off-by: Milo Kim >> --- >> arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts >> index ec63d10..be3668f 100644 >> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts >> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts >> @@ -45,6 +45,11 @@ >> / { >> model = "FriendlyArm NanoPi M1"; >> compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3"; >> + >> + memory@40000000 { >> + device_type = "memory"; >> + reg = <0x40000000 0x20000000>; >> + }; > > U-boot will fill that up, so there's no need to put it there. Right, my intention was adding memblock through the DT whether the bootload does or not. However I'm not sure the situation (missing memblock in u-boot) could really happen. Best regards, Milo