From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758502AbcH3Ucr (ORCPT ); Tue, 30 Aug 2016 16:32:47 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35664 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbcH3Uco (ORCPT ); Tue, 30 Aug 2016 16:32:44 -0400 Date: Wed, 31 Aug 2016 02:02:40 +0530 From: Bhaktipriya Shridhar To: David Howells Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH v2 1/4] fs/afs/vlocation: Remove deprecated create_singlethread_workqueue Message-ID: <960cff8a55c83c0d8846306c1b286ec545e9e5f4.1472589043.git.bhaktipriya96@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The workqueue "afs_vlocation_update_worker" queues a single work item &afs_vlocation_update and hence it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. Since the workqueue is being used on a memory reclaim path, WQ_MEM_RECLAIM flag has been set to ensure forward progress under memory pressure. Since there are fixed number of work items, explicit concurrency limit is unnecessary here. Signed-off-by: Bhaktipriya Shridhar --- Changes in v2: -No change. fs/afs/vlocation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c index 5297678..45a8639 100644 --- a/fs/afs/vlocation.c +++ b/fs/afs/vlocation.c @@ -594,8 +594,8 @@ static void afs_vlocation_reaper(struct work_struct *work) */ int __init afs_vlocation_update_init(void) { - afs_vlocation_update_worker = - create_singlethread_workqueue("kafs_vlupdated"); + afs_vlocation_update_worker = alloc_workqueue("kafs_vlupdated", + WQ_MEM_RECLAIM, 0); return afs_vlocation_update_worker ? 0 : -ENOMEM; } -- 2.1.4