From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Ira Weiny <ira.weiny@intel.com>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [RFC PATCH] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM
Date: Wed, 17 Aug 2022 23:42:39 +0000 [thread overview]
Message-ID: <960e89d2-b32a-4da7-97fe-7157f905fa9f@nvidia.com> (raw)
In-Reply-To: <3177256.oiGErgHkdL@opensuse>
> @Chaitanya:
>
> Since this is a mere simplification and shorten of code, I suppose I can skip
> the performance tests. Ira and I have still hundreds of call sites with kmap()
> and kmap_atomic() which we should care of, therefore we prefer to leave alone
> everything that is not strictly necessary for the deprecated API deletions.
>
> Thanks to you all,
>
fine by me.
-ck
next prev parent reply other threads:[~2022-08-17 23:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 9:18 [RFC PATCH] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM Fabio M. De Francesco
2022-08-16 13:12 ` Chaitanya Kulkarni
2022-08-16 18:16 ` Fabio M. De Francesco
2022-08-16 18:59 ` Keith Busch
2022-08-17 9:44 ` Sagi Grimberg
2022-08-17 12:02 ` Fabio M. De Francesco
2022-08-17 23:42 ` Chaitanya Kulkarni [this message]
2022-08-17 14:18 ` Keith Busch
2022-08-17 14:25 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960e89d2-b32a-4da7-97fe-7157f905fa9f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).