linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: david singleton <dsingleton@mvista.com>
To: Andrew Morton <akpm@osdl.org>
Cc: robustmutexes@lists.osdl.org, chaosite@gmail.com,
	linux-kernel@vger.kernel.org, daviado@gmail.com
Subject: Re [robust-futex-2] : interdiff for memory leak fix
Date: Mon, 16 Jan 2006 11:09:15 -0800	[thread overview]
Message-ID: <961FB9D6-86C3-11DA-B27C-000A959BB91E@mvista.com> (raw)
In-Reply-To: <20060114122521.39f86ed5.akpm@osdl.org>


   Here is an interdiff for a memory leak fix in register_futex.  The 
nice thing
about the slab caches are the ability to spot leaks easily.

diff -u linux-2.6.15/kernel/futex.c linux-2.6.15/kernel/futex.c
--- linux-2.6.15/kernel/futex.c
+++ linux-2.6.15/kernel/futex.c
@@ -1129,6 +1133,8 @@
         if (vma->vm_file && vma->vm_file->f_mapping) {
                 if (vma->vm_file->f_mapping->robust_head == NULL)
                         init_robust_list(vma->vm_file->f_mapping, 
file_futex);
+               else
+                       kmem_cache_free(file_futex_cachep, file_futex);
                 head = 
&vma->vm_file->f_mapping->robust_head->robust_list;
                 sem = &vma->vm_file->f_mapping->robust_head->robust_sem;
         } else {

although Safari seems to always translates tabs to spaces.

David


      reply	other threads:[~2006-01-16 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b324b5ad0601131316m721f959eu37b741f9e5557a2e@mail.gmail.com>
2006-01-13 21:27 ` Robust futex patch for Linux 2.6.15 Andrew Morton
2006-01-13 22:20   ` Andi Kleen
2006-01-13 23:01     ` Andrew Morton
2006-01-14 16:13   ` Matan Peled
2006-01-14 20:25     ` Andrew Morton
2006-01-16 19:09       ` david singleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=961FB9D6-86C3-11DA-B27C-000A959BB91E@mvista.com \
    --to=dsingleton@mvista.com \
    --cc=akpm@osdl.org \
    --cc=chaosite@gmail.com \
    --cc=daviado@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robustmutexes@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).