From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D6DC433DF for ; Tue, 11 Aug 2020 22:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81E46206C3 for ; Tue, 11 Aug 2020 22:09:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="t2K1Wp1Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbgHKWJv (ORCPT ); Tue, 11 Aug 2020 18:09:51 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:44571 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbgHKWJv (ORCPT ); Tue, 11 Aug 2020 18:09:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597183790; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=8nVYNeSoMlj/0DZnpTkkfpxc5/vnT3kxypEjr4vqN8U=; b=t2K1Wp1Z8uaHGZM/Ds/ii4l57tiDZmmGN+pnAm/L4QmhHNBKNZdc7C5u3NV0qbbJtNwDOOPK kBNzX0wX6f7lXxjybB9DZHWJ8b/r4UEwC9K1hWjegMuD+EavhC+Bj/Hryw2QYbzJ15J776Wj m7QiTAhxFHNh8jIes1B5FcrA6RE= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5f331729ba4c2cd367d667e7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 11 Aug 2020 22:09:45 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D10C1C4339C; Tue, 11 Aug 2020 22:09:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tanmay) by smtp.codeaurora.org (Postfix) with ESMTPSA id E81ABC433C6; Tue, 11 Aug 2020 22:09:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 11 Aug 2020 15:09:43 -0700 From: Tanmay Shah To: Randy Dunlap Cc: David Airlie , linux-arm-msm , Linux Kernel Mailing List , dri-devel , Stephen Boyd , khsieh@codeaurora.org, Rob Clark , Sean Paul , Abhinav Kumar , Daniel Vetter , Vara Reddy , aravindh@codeaurora.org, freedreno , Chandan Uddaraju Subject: Re: [Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver In-Reply-To: <7222ceca-9fe2-f91b-4129-5a70952875f7@infradead.org> References: <20200807071718.17937-1-tanmay@codeaurora.org> <20200807071718.17937-4-tanmay@codeaurora.org> <3b0d0e49-5fe8-e217-4ddc-1ff08e65ab48@infradead.org> <159683184187.1360974.15575847254880429529@swboyd.mtv.corp.google.com> <75acac5a-b4a5-9c5a-4404-fb936d738e46@infradead.org> <639438051c1b2fe1d9bec5f6343a6dec@codeaurora.org> <7222ceca-9fe2-f91b-4129-5a70952875f7@infradead.org> Message-ID: <9624e970765dc0739793612c2a5c53bc@codeaurora.org> X-Sender: tanmay@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-11 13:21, Randy Dunlap wrote: > On 8/11/20 12:49 PM, tanmay@codeaurora.org wrote: >> On 2020-08-07 13:28, Randy Dunlap wrote: >>> On 8/7/20 1:24 PM, Stephen Boyd wrote: >>>> Quoting Rob Clark (2020-08-07 08:51:48) >>>>> On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap >>>>> wrote: >>>>>> >>>>>> On 8/7/20 12:17 AM, Tanmay Shah wrote: >>>>>>> diff --git a/drivers/gpu/drm/msm/Kconfig >>>>>>> b/drivers/gpu/drm/msm/Kconfig >>>>>>> index ea3c4d094d09..cc1392b29022 100644 >>>>>>> --- a/drivers/gpu/drm/msm/Kconfig >>>>>>> +++ b/drivers/gpu/drm/msm/Kconfig >>>>>>> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP >>>>>>>  config DRM_MSM_DP >>>>>>>       bool "Enable DP support in MSM DRM driver" >>>>>>>       depends on DRM_MSM >>>>>>> +     default y >>>>>>>       help >>>>>>>         Compile in support for DP driver in msm drm driver. DP >>>>>>> external >>>>>>>         display support is enabled through this config option. It >>>>>>> can >>>>>> >>>>>> Hi, >>>>>> >>>>>> You need a very strong justification to make an optional part of a >>>>>> driver >>>>>> to be "default y". >>>>> >>>>> My opinion is that if the driver is built, everything should be >>>>> built. >>>>> This is what makes sense for distro's.  It is only the embedded >>>>> case >>>>> where you want to trim down unneeded features where you might want >>>>> to >>>>> disable some parts.  So 'default y' makes sense to me. >>> >>> We don't set defaults for distro convenience. >>> >>>> >>>> Maybe use 'default DRM_MSM' so that it doesn't trigger the 'default >>>> y' >>>> filters people have? >>> >>> Most people can figure that one out.  ;) >>> I don't have any automated filters. >> >> After after further reviews, I agree with Rob. Display Port is >> required module as of now so it makes sense to keep 'default y'. > > If it is required, then you don't need to have a Kconfig entry/symbol > for it. Kconfig makes driver flexible. Other moudles in the driver are also 'default y' such as DSI. I will let Rob guide us further on this as he is the maintainer.