From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B64DC282DD for ; Thu, 23 May 2019 21:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0CEB21773 for ; Thu, 23 May 2019 21:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="lydjv4HV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388322AbfEWVw6 (ORCPT ); Thu, 23 May 2019 17:52:58 -0400 Received: from node.akkea.ca ([192.155.83.177]:49564 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387709AbfEWVw5 (ORCPT ); Thu, 23 May 2019 17:52:57 -0400 Received: by node.akkea.ca (Postfix, from userid 33) id EE1D44E204B; Thu, 23 May 2019 21:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1558648376; bh=EEx6+r+EW8Gn9LAjThkYPyrhI3Zs+zGHNmTtqinmKv4=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=lydjv4HV77oK6COWSrTB1aH1fzxQCpWZn3f9c5YJdUPbwSs9j4jrs+wewljakLQ7n SuVyaPb07lQ5iHRWYIVaoMcXhR2PcSdEsn9Gj4eL9enTjgl4octPYeaEFmGc7eJJ+x uVBAjCgayvFpSuhgomr0JoIhmwvSb+a0fFBEHF90= To: Pavel Machek Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 May 2019 14:52:56 -0700 From: Angus Ainslie Cc: angus.ainslie@puri.sm, Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org In-Reply-To: <20190523191922.GA3803@xo-6d-61-c0.localdomain> References: <20190520142330.3556-1-angus@akkea.ca> <20190520142330.3556-3-angus@akkea.ca> <20190523191922.GA3803@xo-6d-61-c0.localdomain> Message-ID: <9626cd324eaaab2b49c37cf3c824aa5e@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On 2019-05-23 12:19, Pavel Machek wrote: > Hi! > >> This is for the development kit board for the Librem 5. The current >> level >> of support yields a working console and is able to boot userspace from >> the network or eMMC. >> >> Additional subsystems that are active : > >> - haptic motor > > Haptic motor is not a LED. It should be controlled by input subsystem. > >> + pwmleds { >> + compatible = "pwm-leds"; >> + >> + haptic { >> + label = "librem5::haptic"; >> + pwms = <&pwm2 0 200000>; >> + active-low; >> + max-brightness = <255>; >> + power-supply = <®_3v3_p>; >> + }; >> + }; > > You can take a look at N900, that has reasonable interface. > I wanted to control the haptic with the pwm-vibra driver but "fsl,imx27-pwm" doesn't seem to respect the PWM_POLARITY_INVERTED flag so when I start the system the vibrator is full on. I could use gpio-vibrator but that seemed like a waste when the device is connected to pwm. I figured the using the pwm-leds interface was a reasonable compromise until I had an opportunity to make changes the the imx27-pwm driver. Thanks Angus > Thanks, > Pavel