From: Viresh Kumar <viresh.kumar@st.com>
To: <akpm@linux-foundation.org>, <rui.zhang@intel.com>
Cc: <armando.visconti@st.com>, <shiraz.hashim@st.com>,
<vipin.kumar@st.com>, <rajeev-dlh.kumar@st.com>,
<deepak.sikri@st.com>, <vipulkumar.samar@st.com>,
<amit.virdi@st.com>, <viresh.kumar@st.com>,
<pratyush.anand@st.com>, <bhupesh.sharma@st.com>,
<viresh.linux@gmail.com>, <bhavna.yadav@st.com>,
<vincenzo.frascino@st.com>, <mirko.gardi@st.com>,
<salvatore.dedominicis@st.com>, <linux-kernel@vger.kernel.org>,
<len.brown@intel.com>
Subject: [PATCH 1/2] thermal/spear_thermal: Replace readl/writel with lighter _relaxed variants
Date: Mon, 27 Feb 2012 09:41:39 +0530 [thread overview]
Message-ID: <963d5aaac84ad075c4cfbd2babc5d264e2157502.1330315545.git.viresh.kumar@st.com> (raw)
readl/writel versions for ARM contain memory barrier instruction for
synchronizing DMA buffers. These are not required atleast on this module. So use
lighter _relaxed variants.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
Hi Andrew,
These patches are rebased over all three patches you have applied on your tree.
drivers/thermal/spear_thermal.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
index 880bf28..be94413 100644
--- a/drivers/thermal/spear_thermal.c
+++ b/drivers/thermal/spear_thermal.c
@@ -46,7 +46,7 @@ static inline int thermal_get_temp(struct thermal_zone_device *thermal,
* Data are ready to be read after 628 usec from POWERDOWN signal
* (PDN) = 1
*/
- *temp = (readl(stdev->thermal_base) & 0x7F) * MD_FACTOR;
+ *temp = (readl_relaxed(stdev->thermal_base) & 0x7F) * MD_FACTOR;
return 0;
}
@@ -63,8 +63,8 @@ static int spear_thermal_suspend(struct device *dev)
unsigned int actual_mask = 0;
/* Disable SPEAr Thermal Sensor */
- actual_mask = readl(stdev->thermal_base);
- writel(actual_mask & ~stdev->flags, stdev->thermal_base);
+ actual_mask = readl_relaxed(stdev->thermal_base);
+ writel_relaxed(actual_mask & ~stdev->flags, stdev->thermal_base);
clk_disable(stdev->clk);
dev_info(dev, "Suspended.\n");
@@ -87,8 +87,8 @@ static int spear_thermal_resume(struct device *dev)
}
/* Enable SPEAr Thermal Sensor */
- actual_mask = readl(stdev->thermal_base);
- writel(actual_mask | stdev->flags, stdev->thermal_base);
+ actual_mask = readl_relaxed(stdev->thermal_base);
+ writel_relaxed(actual_mask | stdev->flags, stdev->thermal_base);
dev_info(dev, "Resumed.\n");
@@ -145,7 +145,7 @@ static int spear_thermal_probe(struct platform_device *pdev)
}
stdev->flags = pdata->thermal_flags;
- writel(stdev->flags, stdev->thermal_base);
+ writel_relaxed(stdev->flags, stdev->thermal_base);
spear_thermal = thermal_zone_device_register("spear_thermal", 0,
stdev, &ops, 0, 0, 0, 0);
@@ -180,8 +180,8 @@ static int spear_thermal_exit(struct platform_device *pdev)
platform_set_drvdata(pdev, NULL);
/* Disable SPEAr Thermal Sensor */
- actual_mask = readl(stdev->thermal_base);
- writel(actual_mask & ~stdev->flags, stdev->thermal_base);
+ actual_mask = readl_relaxed(stdev->thermal_base);
+ writel_relaxed(actual_mask & ~stdev->flags, stdev->thermal_base);
clk_disable(stdev->clk);
clk_put(stdev->clk);
--
1.7.8.110.g4cb5d
next reply other threads:[~2012-02-27 4:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 4:11 Viresh Kumar [this message]
2012-02-27 4:11 ` [PATCH 2/2] thermal/spear_thermal: Add compilation dependency on PLAT_SPEAR Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963d5aaac84ad075c4cfbd2babc5d264e2157502.1330315545.git.viresh.kumar@st.com \
--to=viresh.kumar@st.com \
--cc=akpm@linux-foundation.org \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=rui.zhang@intel.com \
--cc=salvatore.dedominicis@st.com \
--cc=shiraz.hashim@st.com \
--cc=vincenzo.frascino@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).