From: Neil Armstrong <narmstrong@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: khilman@baylibre.com, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: amlogic: Add Internal Clock Measurer bindings
Date: Tue, 17 Jul 2018 13:30:38 +0200 [thread overview]
Message-ID: <964512dd-fddb-4919-446a-96db7cc22a8b@baylibre.com> (raw)
In-Reply-To: <20180716214516.GA31738@rob-hp-laptop>
Hi Rob,
On 16/07/2018 23:45, Rob Herring wrote:
> On Tue, Jul 03, 2018 at 03:21:49PM +0200, Neil Armstrong wrote:
>> The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal
>> clock paths frequencies.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../devicetree/bindings/soc/amlogic/clk-measure.txt | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt
>>
>> diff --git a/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt
>> new file mode 100644
>> index 0000000..ba9183a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt
>> @@ -0,0 +1,15 @@
>> +Amlogic Internal Clock Measurer
>> +===============================
>> +
>> +The Amlogic SoCs contains an IP to measure the internal clocks.
>> +The precision is multiple of MHz, useful to debug the clock states.
>
> What a simple yet useful debug tool.
>
>> +
>> +Required properties:
>> +- compatible: Shall contain "amlogic,meson-gx-clk-measure"
>> +- reg: base address and size of the Clock Measurer register space.
>> +
>> +Example:
>> + clock-measure@8758 {
>> + compatible = "amlogic,meson-gx-clk-measure";
>> + reg = <0x0 0x8758 0x0 0x10>;
>
> This doesn't really look like its own block though. Can't the parent
> device instantiate the driver for this?
As weird as it seems, on the GX family the registers are not on a aligned boundary, but yes it's its own block.
On newer SoCs, they have a more aligned register address, with the exact same register set.
Neil
>
>
>> + };
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-07-17 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 13:21 [PATCH 0/3] Add Amlogic Meson GX SoC Clock Measure Driver Neil Armstrong
2018-07-03 13:21 ` [PATCH 1/3] soc: amlogic: Add Meson GX Clock Measure driver Neil Armstrong
2018-07-03 14:31 ` Neil Armstrong
2018-07-03 19:18 ` Martin Blumenstingl
2018-07-04 8:41 ` Neil Armstrong
2018-07-04 13:44 ` Martin Blumenstingl
2018-07-09 21:41 ` Kevin Hilman
2018-07-11 8:37 ` Neil Armstrong
2018-07-14 14:41 ` Martin Blumenstingl
2018-07-16 8:41 ` Jerome Brunet
2018-07-03 13:21 ` [PATCH 2/3] dt-bindings: amlogic: Add Internal Clock Measurer bindings Neil Armstrong
2018-07-16 21:45 ` Rob Herring
2018-07-17 11:30 ` Neil Armstrong [this message]
2018-07-03 13:21 ` [PATCH 3/3] ARM64: dts: meson-gx: Add Internal Clock Measurer node Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964512dd-fddb-4919-446a-96db7cc22a8b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).