From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF68C433ED for ; Tue, 27 Apr 2021 03:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C2EB611BE for ; Tue, 27 Apr 2021 03:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234375AbhD0Drp (ORCPT ); Mon, 26 Apr 2021 23:47:45 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:43008 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhD0Drn (ORCPT ); Mon, 26 Apr 2021 23:47:43 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 632AB21FEC; Mon, 26 Apr 2021 23:46:58 -0400 (EDT) Date: Tue, 27 Apr 2021 13:47:04 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: John Paul Adrian Glaubitz , Geert Uytterhoeven , Christoph Hellwig , Joshua Thompson , "David S. Miller" , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] m68k/mac: Replace macide driver with generic platform driver In-Reply-To: <65f01f42-31d9-522a-e690-73d286405a01@gmail.com> Message-ID: <9650358f-a789-7dbd-4495-1d39ff321ded@nippy.intranet> References: <793432cca963b632709c4d1312baa9874d73e1d8.1619341585.git.fthain@telegraphics.com.au> <10a08764-c138-9fe5-966c-ce68349b9b6@nippy.intranet> <65f01f42-31d9-522a-e690-73d286405a01@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Apr 2021, Michael Schmitz wrote: > On 26/04/21 7:37 pm, Finn Thain wrote: > > Was macide the only IDE driver in Debian/m68k kernels without a libata > > alternative? If so, this patch would allow you to finally drop > > CONFIG_IDE. > > > There's still q40ide.c (ISA IDE interface, byte-swapped, so would need > treatment similar to Falcon IDE). Hasn't been updated to a platform > device yet. > AIUI, q40 support is not included in Debian/m68k kernel builds. I wonder whether q40 could re-use the pata_falcon driver . I suppose pata_falcon_set_mode() would be undesirable on q40 (?) It could be made optional using the data parameter passed to platform_device_register_resndata().