From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbcEJIhq (ORCPT ); Tue, 10 May 2016 04:37:46 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:50018 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcEJIhn (ORCPT ); Tue, 10 May 2016 04:37:43 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: "Zhangjian (Bamvor)" , Yury Norov , linux-doc@vger.kernel.org, Andrew Pinski , catalin.marinas@arm.com, heiko.carstens@de.ibm.com, Hanjun Guo , joseph@codesourcery.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, "jijun (D)" , Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, agraf@suse.de, pinskia@gmail.com, klimov.linux@gmail.com, broonie@kernel.org, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, Andrew Pinski , schwidefsky@de.ibm.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Tue, 10 May 2016 10:36:40 +0200 Message-ID: <9651510.pg5Vmm8vKS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <573190CF.6030408@huawei.com> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <20160506123731.GA11959@yury-N73SV> <573190CF.6030408@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:I7wPsjgzHEQjXqqMnrCCo1ZRzyBOtJUUpKCRaEuemHovS5gK5vD +9b9YeKfe4J4f0RjoNEW2wLnXtNlq9d2QJf/DHTh157l/3I4f3Utp1BjAiu7F03CSgvVhao ND8LAasGREDYdRoGVyW7Nnn0birRmG3mQlTcTLc9OPS11XEYbCF4p2x7I9E38vYTQZg6quh IY8N7LS8lnC8VT7JNWKqQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:bt4cddP8I+U=:qBKZFRwkrKzqoc5C8d54uk 0TTBoemdR6IH85qTe5jdUuCtt9fJZJbdsMpZ9Hry9GeBFpNQggKYBwK7WEbZoa2QJbnbvLLGI leEgYar4QcOjPKMDlW8pidjVqaN1S8+KIn4KOZcWrArpqtfAquMmixfELsbeTZ557TNRh+t4R WD+uK/pNLdi/uMB4mA36df89hfLyCEgt1ZO+pHX1x2KwQsZpgqd2swUmXr2jb+Y6Z3YsaBcGv 7lcRRZb7DHvb2q2oc2/z51f/+JqyNSkrS4yE1pi+mDXABH45jjKra0wWbWn+R6G9e//wjwZCL 7856YxDqSTVjU4sdBkV22XuVooNkRxas6SrLD8b+2eS06qgSMHyPwlAp6ZA74wxxjye/WB1/q +m7ga5IXazVYK9yDxckZ6zZv/MLVSwLHVVIeFF8OkcsAKyw70zGHyt/Q6CI0jc4BW3/FhyCLj hZKbuWZOfsQkG3kHKzPtypqgigc0pCOowFsX7UaEh/r1SEuR5fGFElI/Q3pHW4UR2WLxOzsYq irfFc0QEas7/Cfulzt3iEwpxhXWoVoRwegX4/Fq5sua/0GfdTabaJwU1SErkowCMIPKsgNCRw UPtOP4ldouMjblzIncncqpCFkQORCaskYE9wFyBhegblicqyjzZ224RDmqd5WEL3G1FBBrwpH IQopd7l5LnSDToNUgbcNyD+ZaZ9wEkQ4vkNFCBPt3DL4WdrPjcAO5OE/x9aZ5QT8FbwfU+VXr CdH6uhfksJ+HUXmW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 May 2016 15:42:07 Zhangjian wrote: > On 2016/5/6 20:37, Yury Norov wrote: > > On Fri, May 06, 2016 at 08:16:48PM +0800, Zhangjian (Bamvor) wrote: > > > > AFAIR, here we don't shift offset, as it's 64-bit both in user- > > and kernel-space, > In your ilp32-2.22 branch, you wrapper mmap to mmap2 in which type of > offset is off_t. And off_t is 32bit in ilp32, correct? > "sysdeps/unix/sysv/linux/aarch64/ilp32/mmap64.c" > /* mmap is provided by mmap as they are the same. */ > void *__mmap (void *__addr, size_t __len, int __prot, > int __flags, int __fd, __off_t __offset) > { > void *result; > result = (void *) > INLINE_SYSCALL (mmap2, 6, __addr, > __len, __prot, __flags, __fd, __offset); > return result; > } __off_t should be 'long long' on new architectures, and map to __kernel_loff_t. Can you see how it is defined? Arnd